Fix for iOS 9 Banner not taking navigation bars into account properly#20
Open
dtrotzjr wants to merge 1 commit intothibault-carpentier:masterfrom
Open
Fix for iOS 9 Banner not taking navigation bars into account properly#20dtrotzjr wants to merge 1 commit intothibault-carpentier:masterfrom
dtrotzjr wants to merge 1 commit intothibault-carpentier:masterfrom
Conversation
This appears to be a bug in iOS 9? The statement `realtViewController.topLayoutGuide` seems to go away at some point after we set it here. To be clear it is not `nil` at run time when `[... constraintWithItem:realViewController.topLayoutGuide ...]` is called however when I bring this up in Reveal App the constraint is labeled as `???.bottom = MBLMessageBannerView:0x...` and the `First Item` is `Unknown`. After a few hours banging my head against a wall this was the best I could come up with and it seems to work but I am skeptical as to how robust this really is.
Owner
|
Thanks for the pull request. This can be used as a quickfix is someone really need a fast fix. I will take a look this weekend to see how this can be improved. |
|
Yes, I agree this is not a proper fix long term, and is more of a quick hack to keep things moving while the proper solution is found. |
Contributor
|
Was a long term fix ever implemented? Also MessageBanner really doesn't like use_frameworks! in CocoaPods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is based in part @loadex's
feature/newTopLayoutbranch.This issue appears to be caused by a bug in iOS 9?
The statement
realtViewController.topLayoutGuideseems to go away at some point after we set it here. To be clear it is notnilat run time when[... constraintWithItem:realViewController.topLayoutGuide ...]is called however when I bring this up in Reveal App the constraint is labeled as???.bottom = MBLMessageBannerView:0x...and theFirst ItemisUnknown.After a few hours banging my head against a wall this was the best I could come up with and it seems to work but I am skeptical as to how robust this really is.