[18.0][MIG] account_invoice_auto_send_by_email: Migration to 18.0#2
Open
thienvh332 wants to merge 7 commits into18.0from
Open
[18.0][MIG] account_invoice_auto_send_by_email: Migration to 18.0#2thienvh332 wants to merge 7 commits into18.0from
thienvh332 wants to merge 7 commits into18.0from
Conversation
…end email account
simahawk
suggested changes
Nov 13, 2024
simahawk
left a comment
There was a problem hiding this comment.
@thienvh332 thanks for the attempt. However, I think we are still far from the final result.
Major points:
- transmit method becomes useless when using the framework -> it will be replaced by the edi.conf + specifc edi exc type
- the whole modules (send by email and a_inv_trans_method) can be trashed or left behind if someone wants still to use them as they are because everything can be done now in
edi_account_oca
There you can define:
- a configuration
- a field for supplier conf
- a field for customer conf
- a listener
Please put this on hold for a while till we clarify how all the modules using transmit method should modified or discarded in our flow.
| "category": "Accounting", | ||
| "author": "Camptocamp, Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", | ||
| "depends": ["account", "account_invoice_transmit_method", "edi_account_oca"], |
There was a problem hiding this comment.
What is the role of account_invoice_transmit_method?
| @@ -0,0 +1,9 @@ | |||
| <odoo> | |||
| <record id="edi_conf_send_via_email" model="edi.configuration"> | |||
There was a problem hiding this comment.
Who's going to use this? We need a specific field on the partner to make use of this w/ a proper trigger option added to the edi.conf model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
https://github.com/OCA/account-invoicing/pull/1382#issuecomment-1691643856)edi.configurationand edi flow for sending mail. Allow users to customize and intervene in this mail sending process.Depends on:
https://github.com/OCA/server-tools/pull/3100