[18.0][MIG] storage_backend_ftp: Migration to 18.0#16
Closed
thienvh332 wants to merge 23 commits into18.0from
Closed
[18.0][MIG] storage_backend_ftp: Migration to 18.0#16thienvh332 wants to merge 23 commits into18.0from
thienvh332 wants to merge 23 commits into18.0from
Conversation
* list should return a python list of files. * get should get and directly return the bynary from the FTP. Before, a string was being retrived and then encoded. This is problematic if the original binary was not utf-8.
Currently translated at 4.3% (1 of 23 strings) Translation: storage-14.0/storage-14.0-storage_backend_ftp Translate-URL: https://translation.odoo-community.org/projects/storage-14-0/storage-14-0-storage_backend_ftp/it/
nilshamerlinck
suggested changes
Apr 3, 2025
nilshamerlinck
left a comment
nilshamerlinck
left a comment
There was a problem hiding this comment.
thanks, any chance to get a description that might explain why the timeout=30 change?
Owner
Author
It comes from the pre-commit message below. Should I add it to the PR description?
|
|
yes, please, a reviewer might wonder why this change |
Owner
Author
|
Updated PR description, Thanks sir 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.