Skip to content

Conversation

@r-marques
Copy link

@r-marques r-marques commented Apr 29, 2025

Changes

  • updates isValidWebhookUrl to allow using host.docker.internal with the http protocol
  • updates the validator unit tests to check if http://host.docker.internal:3000 is a valid webhook url

This makes it possible to set webhooks for services running on the host when developing locally and running the engine with docker


PR-Codex overview

This PR updates the validation logic for webhook URLs to include host.docker.internal as a valid hostname for HTTP requests, enhancing local development compatibility.

Detailed summary

  • Added a test case in tests/unit/validator.test.ts to validate http://host.docker.internal:3000.
  • Modified the validation logic in src/server/utils/validator.ts to include host.docker.internal in the list of allowed hostnames for HTTP.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@r-marques r-marques changed the title feat: allow host.docker.internal with http when creating a webhook Consider allowing host.docker.internal with the http protocol for local development Apr 29, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days.

@r-marques
Copy link
Author

Any update on this?

@github-actions
Copy link

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant