Skip to content

Dashboard import paths cleanup #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented May 30, 2025


PR-Codex overview

This PR focuses on updating import paths and enhancing code structure across various files in the apps/dashboard directory. It introduces new imports and removes outdated ones to streamline the codebase.

Detailed summary

  • Updated import paths for getClientThirdwebClient and serverThirdwebClient to use absolute paths.
  • Added imports for useAllChainsData, useTrack, and RenewSubscriptionButton in multiple files.
  • Removed unused or redundant imports throughout the codebase.
  • Enhanced consistency in import statements across components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 6:59pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 30, 2025 6:59pm
login ⬜️ Skipped (Inspect) May 30, 2025 6:59pm
thirdweb_playground ⬜️ Skipped (Inspect) May 30, 2025 6:59pm
wallet-ui ⬜️ Skipped (Inspect) May 30, 2025 6:59pm

Copy link

changeset-bot bot commented May 30, 2025

🦋 Changeset detected

Latest commit: 9b1466d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 30, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 30, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 30, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 30, 2025 18:32 Inactive
Copy link
Contributor

coderabbitai bot commented May 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member Author

MananTank commented May 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.62%. Comparing base (e171fb9) to head (cc1a16b).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           graphite-base/7229    #7229   +/-   ##
===================================================
  Coverage               55.62%   55.62%           
===================================================
  Files                     908      908           
  Lines                   58570    58570           
  Branches                 4133     4133           
===================================================
  Hits                    32577    32577           
  Misses                  25886    25886           
  Partials                  107      107           
Flag Coverage Δ
packages 55.62% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.15 KB (0%) 1.3 s (0%) 401 ms (+20.4% 🔺) 1.7 s
thirdweb (cjs) 344.84 KB (0%) 6.9 s (0%) 2.5 s (+4.73% 🔺) 9.4 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 69 ms (+211.48% 🔺) 183 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 29 ms (+272.12% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.52 KB (0%) 391 ms (0%) 133 ms (+168.05% 🔺) 523 ms

@graphite-app graphite-app bot changed the base branch from 05-30-dashboard_remove_usethirdwebclient_hook to graphite-base/7229 May 30, 2025 18:37
Copy link
Contributor

graphite-app bot commented May 30, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating import paths and enhancing code structure across various files in the `apps/dashboard` directory. It introduces new imports and removes outdated ones to streamline the codebase.

### Detailed summary
- Updated import paths for `getClientThirdwebClient` and `serverThirdwebClient` to use absolute paths.
- Added imports for `useAllChainsData`, `useTrack`, and `RenewSubscriptionButton` in multiple files.
- Removed unused or redundant imports throughout the codebase.
- Enhanced consistency in import statements across components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 05-31-dashboard_import_paths_cleanup branch from cc1a16b to 9b1466d Compare May 30, 2025 18:51
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 30, 2025 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 30, 2025 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 30, 2025 18:52 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 30, 2025 18:52 Inactive
@graphite-app graphite-app bot changed the base branch from graphite-base/7229 to 05-30-dashboard_remove_usethirdwebclient_hook May 30, 2025 18:52
Base automatically changed from 05-30-dashboard_remove_usethirdwebclient_hook to main May 30, 2025 19:00
@jnsdls jnsdls merged commit e141e11 into main May 30, 2025
12 checks passed
@jnsdls jnsdls deleted the 05-31-dashboard_import_paths_cleanup branch May 30, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants