SDK: Fallback to insight response if RPC request fails in getNFTs extensions

[MananTank]

---

PR-Codex overview

This PR focuses on improving the getNFTs functionality in the ERC721 and ERC1155 extensions by adding error handling for RPC requests. It also makes minor adjustments to the table components in the dashboard.

Detailed summary

• Added a key="drawer" to the empty header in table.tsx and marketplace-table.tsx.
• Enhanced error handling in getNFTs for ERC721 and ERC1155:
  • Wrapped RPC request in a try-catch block.
  • Fallback to returning results from insight if RPC fails.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

• New Features

  • Improved NFT fetching reliability by introducing a fallback mechanism that retrieves data from an alternative source if the primary method fails.

• Bug Fixes

  • Enhanced error handling to ensure partial NFT data is returned if both primary and fallback data sources encounter issues.
  • Added unique keys to specific table header elements to improve stability and rendering in marketplace and NFT tables.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2025 9:50pm

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)			May 30, 2025 9:50pm
login	⬜️ Skipped (Inspect)			May 30, 2025 9:50pm
thirdweb_playground	⬜️ Skipped (Inspect)			May 30, 2025 9:50pm
wallet-ui	⬜️ Skipped (Inspect)			May 30, 2025 9:50pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 3dfdb3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This update introduces improved error handling and fallback logic in NFT retrieval methods for ERC721 and ERC1155 extensions, ensuring partial data is returned if both primary and fallback sources fail. Additionally, React table header components in the dashboard are updated to include unique keys for empty header cells related to drawer buttons.

Changes

File(s)	Change Summary
packages/thirdweb/src/extensions/erc1155/read/getNFTs.ts packages/thirdweb/src/extensions/erc721/read/getNFTs.ts	Updated fallback logic: now wraps RPC fallback in try-catch, returning partial insight data if both sources fail.
apps/dashboard/src/app/.../marketplace-table.tsx apps/dashboard/src/app/.../nfts/components/table.tsx	Added key="drawer" to empty <Th> elements for drawer columns in table headers to ensure unique React keys.
.changeset/shaggy-tables-care.md	Added changeset describing the fallback mechanism enhancement in NFT fetching extensions.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant ERC721/1155 getNFTs
    participant RPC
    participant InsightAPI

    App->>ERC721/1155 getNFTs: Request NFTs
    ERC721/1155 getNFTs->>RPC: Fetch NFTs via RPC
    alt RPC Success
        RPC-->>ERC721/1155 getNFTs: Return NFTs
        ERC721/1155 getNFTs-->>App: Return NFTs
    else RPC Fails
        ERC721/1155 getNFTs->>InsightAPI: Fetch NFTs via Insight API
        alt InsightAPI returns expected count
            InsightAPI-->>ERC721/1155 getNFTs: Return NFTs
            ERC721/1155 getNFTs-->>App: Return NFTs
        else InsightAPI returns less than expected
            InsightAPI-->>ERC721/1155 getNFTs: Return partial NFTs
            ERC721/1155 getNFTs->>RPC: Try fallback RPC (inside try-catch)
            alt RPC fallback succeeds
                RPC-->>ERC721/1155 getNFTs: Return NFTs
                ERC721/1155 getNFTs-->>App: Return NFTs
            else RPC fallback fails
                ERC721/1155 getNFTs-->>App: Return partial NFTs from InsightAPI
            end
        end
    end

Loading

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b458d5 and 3dfdb3c.

📒 Files selected for processing (5)

• .changeset/shaggy-tables-care.md (1 hunks)
• apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/components/marketplace-table.tsx (1 hunks)
• apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/table.tsx (1 hunks)
• packages/thirdweb/src/extensions/erc1155/read/getNFTs.ts (1 hunks)
• packages/thirdweb/src/extensions/erc721/read/getNFTs.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (5)

• apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/components/marketplace-table.tsx
• apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/table.tsx
• .changeset/shaggy-tables-care.md
• packages/thirdweb/src/extensions/erc721/read/getNFTs.ts
• packages/thirdweb/src/extensions/erc1155/read/getNFTs.ts

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: E2E Tests (pnpm, esbuild)
• GitHub Check: Unit Tests
• GitHub Check: E2E Tests (pnpm, webpack)
• GitHub Check: Size
• GitHub Check: E2E Tests (pnpm, vite)
• GitHub Check: Build Packages
• GitHub Check: Lint Packages
• GitHub Check: Analyze (javascript)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[MananTank]

• SDK: Fallback to insight response if RPC request fails in getNFTs extensions #7234 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge-queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	62.14 KB (0%)	1.3 s (0%)	497 ms (+112.19% 🔺)	1.8 s
thirdweb (cjs)	344.83 KB (0%)	6.9 s (0%)	1.9 s (+0.53% 🔺)	8.8 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	89 ms (+594.8% 🔺)	203 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	61 ms (+1094.47% 🔺)	71 ms
thirdweb/react (minimal + tree-shaking)	19.52 KB (+0.01% 🔺)	391 ms (+0.01% 🔺)	140 ms (+222.45% 🔺)	530 ms

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 55.61%. Comparing base (3678054) to head (1285c1d).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...es/thirdweb/src/extensions/erc1155/read/getNFTs.ts	0.00%	5 Missing ⚠️
...ges/thirdweb/src/extensions/erc721/read/getNFTs.ts	0.00%	5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7234      +/-   ##
==========================================
- Coverage   55.62%   55.61%   -0.01%     
==========================================
  Files         908      908              
  Lines       58575    58583       +8     
  Branches     4132     4133       +1     
==========================================
+ Hits        32582    32583       +1     
- Misses      25886    25894       +8     
+ Partials      107      106       -1     

Flag	Coverage Δ
packages	55.61% <0.00%> (-0.01%)	⬇️

Files with missing lines	Coverage Δ
...es/thirdweb/src/extensions/erc1155/read/getNFTs.ts	79.45% <0.00%> (-4.61%)	⬇️
...ges/thirdweb/src/extensions/erc721/read/getNFTs.ts	86.48% <0.00%> (-3.24%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.