Enable React Compiler across all Next.js apps #7329
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughExperimental support for the React Compiler was enabled in the Next.js configuration files for several applications by setting the Changes
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Dashboard
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7329 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 909 909
Lines 58675 58675
Branches 4162 4162
=======================================
Hits 32609 32609
Misses 25959 25959
Partials 107 107
🚀 New features to boost your workflow:
|
jnsdls
force-pushed
the
Enable_React_Compiler_across_all_Next.js_apps
branch
from
1db6d75 to
fadfb9d
Compare
jnsdls
force-pushed
the
06-11-update_deps_2
branch
from
9424247 to
34f9976
Compare
![cursor-com[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jnsdls
force-pushed
the
Enable_React_Compiler_across_all_Next.js_apps
branch
from
fadfb9d to
e2910ec
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jnsdls
force-pushed
the
Enable_React_Compiler_across_all_Next.js_apps
branch
from
0f318e0 to
dfbd304
Compare
jnsdls
force-pushed
the
06-11-update_deps_2
branch
from
f069a7a to
6a28c96
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jnsdls
force-pushed
the
06-11-update_deps_2
branch
from
6a28c96 to
8044d40
Compare
jnsdls
force-pushed
the
Enable_React_Compiler_across_all_Next.js_apps
branch
from
dfbd304 to
0692486
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jnsdls
force-pushed
the
Enable_React_Compiler_across_all_Next.js_apps
branch
from
0692486 to
a697114
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/portal/package.json (1)
75-75: Optional: Add ESLint plugin for React CompilerYou’ve added
babel-plugin-react-compilerbut the correspondingeslint-plugin-react-compilerisn’t present here (other apps include it). For consistent linting of compiler-specific rules, consider adding:"eslint-plugin-react-compiler": "19.1.0-rc.2"to
devDependencies.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
apps/dashboard/next.config.ts(1 hunks)apps/dashboard/package.json(1 hunks)apps/login/next.config.ts(1 hunks)apps/login/package.json(1 hunks)apps/playground-web/next.config.mjs(1 hunks)apps/playground-web/package.json(1 hunks)apps/portal/next.config.mjs(1 hunks)apps/portal/package.json(1 hunks)apps/wallet-ui/next.config.mjs(1 hunks)apps/wallet-ui/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (9)
apps/dashboard/package.json (1)
133-133: DevDependency Added: Babel Plugin for React CompilerThe new
"babel-plugin-react-compiler": "19.1.0-rc.2"entry aligns with the enabled experimental flag and matches versions used across other apps.apps/playground-web/package.json (1)
57-57: DevDependency Added: Babel Plugin for React CompilerAdding
"babel-plugin-react-compiler": "19.1.0-rc.2"here correctly mirrors the setup in sibling apps. Versions are consistent.apps/playground-web/next.config.mjs (1)
48-48: Enabled Experimental React CompilerThe
reactCompiler: trueflag underexperimentalcorrectly activates the React Compiler feature. Ensure your Next.js version (15.3.3) supports this flag and that you rebuild to validate configs.apps/wallet-ui/package.json (1)
43-43: DevDependency Added: Babel Plugin for React CompilerThe addition of
"babel-plugin-react-compiler": "19.1.0-rc.2"is consistent with the rest of the monorepo. Version alignment looks good.apps/wallet-ui/next.config.mjs (1)
57-57: Experimental React Compiler flag enabled.
ThereactCompiler: trueflag is correctly added underexperimental. Ensure your Next.js version (>=13.2) supports this option and that no custom Babel configuration overrides it.apps/portal/next.config.mjs (1)
58-58: Experimental React Compiler flag enabled.
ThereactCompiler: trueflag is correctly added underexperimental. Confirm your Next.js version and validate that the MDX integration remains compatible.apps/dashboard/next.config.ts (1)
127-127: Experimental React Compiler flag enabled.
AddingreactCompiler: trueunderexperimentalaligns with other apps. Verify that your build pipeline picks up the new compiler and that source-map uploads (Sentry integration) still work as expected.apps/login/package.json (1)
43-43: Babel plugin dependency added.
The[email protected]devDependency is correctly introduced. Ensure this version is consistent across all apps and compatible with your React/Next.js versions.apps/login/next.config.ts (1)
5-7: Experimental React Compiler flag enabled.
ThereactCompiler: trueentry underexperimentalis correctly added. Confirm your CI build uses this config and that no other custom Next.js options conflict.
PR-Codex overview
This PR focuses on adding the
reactCompilerfeature across variousnext.configfiles and updating thepackage.jsonfiles to include thebabel-plugin-react-compilerdependency for several applications.Detailed summary
reactCompiler: truetonext.configfiles in:apps/playground-web/next.config.mjsapps/dashboard/next.config.tsapps/login/next.config.tsapps/portal/next.config.mjsapps/wallet-ui/next.config.mjspackage.jsonfiles to include:babel-plugin-react-compilerversion19.1.0-rc.2in:apps/login/package.jsonapps/dashboard/package.jsonapps/portal/package.jsonapps/playground-web/package.jsonapps/wallet-ui/package.jsonpnpm-lock.yamlto reflect the addition ofbabel-plugin-react-compileracross dependencies.Summary by CodeRabbit