Fix comment for max claimable tokens test in drop721.test.ts #7336
Conversation
Signed-off-by: fuder.eth <[email protected]>
|
WalkthroughA comment typo was corrected in a test file related to ERC721 drop functionality. No changes were made to the logic or behavior of the code. Changes
Suggested labels
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
@vtjl10 is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -290,7 +290,7 @@ describe.runIf(process.env.TW_SECRET_KEY)( | |||
| ).resolves.toBe(1n); | |||
|
|
|||
| // we try to claim an extra `2` tokens | |||
| // this should faile bcause the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet) | |||
| // this should faile because the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet) | |||
There was a problem hiding this comment.
There's still a typo in the comment: faile should be fail. The correction is important for maintaining documentation quality, especially since this PR is specifically focused on improving comment clarity.
| // this should faile because the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet) | |
| // this should fail because the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/src/extensions/erc721/drop721.test.ts (1)
293-293: Typo in comment: "faile" is misspelled
The comment still reads “faile” instead of “fail.” Please correct it for clarity.Apply this diff:
- // this should faile because the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet) + // this should fail because the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet)
Description:
This pull request updates a comment in the drop721.test.ts file to clarify the reason for a test failure when attempting to claim more tokens than the allowed maximum. The new comment more clearly explains that the failure occurs because the max claimable is 3 and 2 tokens have already been claimed in previous tests. No functional code changes were made; this is a documentation/comment improvement for better test clarity.
PR-Codex overview
This PR focuses on correcting a comment in the test file
drop721.test.tsto fix a typo regarding the claimable tokens, ensuring clarity in the test's intent.Detailed summary
drop721.test.tsfile.Summary by CodeRabbit