Version Packages #7511
Open
Version Packages #7511
+22
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update increments patch versions for the thirdweb, nebula, and wagmi-adapter packages, documents these changes in their respective changelogs, and removes three changeset files. The main functional changes in thirdweb are a patch to properly type the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (9)
💤 Files with no reviewable changes (3)
🚧 Files skipped from review as they are similar to previous changes (6)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
62b5185 to
cc7b091
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Add at least one bullet so the entry isn’t emptyReaders scanning the changelog won't know why this patch was published.
Consider a minimal note, e.g.:## 0.2.103 +### Patch Changes +* Internal version bump only – aligns peer deps with `[email protected]`packages/thirdweb/CHANGELOG.md (1)
3-8: Add release date to follow existing changelog conventionPrevious entries include the release date on the same header line (or immediately below it in some packages). Including the date makes it easier for users to correlate versions with npm publish events.
-## 5.105.6 +## 5.105.6 – 2025-07-XXFeel free to adjust the exact date when the release is cut.
packages/nebula/package.json (1)
1-61: Addsize-limitbudget tracking to align with workspace guidelinesPer our repo guidelines for every
packages/*/package.json, we should keep an explicit"size-limit"section so bundle budgets are automatically enforced by CI.
The Nebula package already has thesize-limitdev dependency (transitively), but a config entry is still missing here.{ "name": "@thirdweb-dev/nebula", "version": "0.2.6", ... + "size-limit": [ + { + "path": "./dist/esm/exports/thirdweb.js", + "limit": "10 kB" + } + ], "scripts": {Having this in place prevents silent size regressions on future releases.
(Feel free to tweak the path & threshold to realistic numbers based on today’s output.)packages/thirdweb/package.json (1)
400-408:size-limitconfig still missing despite script & dependency being presentThe package already declares the
sizescript that runssize-limit, but there is no"size-limit"field inpackage.json.
Without it the script will exit with code 0 and provide no protection against bundle growth.Consider adding something like:
"scripts": { "size": "size-limit", ... }, + "size-limit": [ + { + "path": "./dist/esm/exports/thirdweb.js", + "limit": "45 kB" + } + ], "sideEffects": false,No action is required for the version bump itself – looks correct and matches the changelog.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/orange-files-admire.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/orange-files-admire.md
🧰 Additional context used
📓 Path-based instructions (1)
`packages/*/package.json`: Track bundle budgets via `package.json#size-limit` De-duplicate dependencies across packages through pnpm workspace hoisting
packages/*/package.json: Track bundle budgets viapackage.json#size-limit
De-duplicate dependencies across packages through pnpm workspace hoisting
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/nebula/package.jsonpackages/thirdweb/package.jsonpackages/wagmi-adapter/package.json
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/*/package.json : De-duplicate dependencies across packages through pnpm workspace hoisting
packages/thirdweb/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/wagmi-adapter/package.json (5)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
Learnt from: MananTank
PR: thirdweb-dev/js#7227
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/OpenEditionMetadata.tsx:26-26
Timestamp: 2025-05-30T17:14:25.332Z
Learning: The ModuleCardUIProps interface already includes a client prop of type ThirdwebClient, so when components use `Omit<ModuleCardUIProps, "children" | "updateButton">`, they inherit the client prop without needing to add it explicitly.
packages/nebula/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
packages/wagmi-adapter/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
packages/thirdweb/CHANGELOG.md (1)
undefined
<retrieved_learning>
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
</retrieved_learning>
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/wagmi-adapter/package.json (1)
58-58: Version bump LGTM
0.2.103correctly follows the existing semver sequence and requires no further changes—peer range^5.85.0already covers[email protected].packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry looks goodVersion bump and dependency note are clear and reference the exact commit. 👍
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7511 +/- ##
=======================================
Coverage 51.87% 51.87%
=======================================
Files 954 954
Lines 64367 64367
Branches 4238 4238
=======================================
Hits 33391 33391
Misses 30868 30868
Partials 108 108
🚀 New features to boost your workflow:
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
cc7b091 to
36a4d1e
Compare
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
36a4d1e to
ef14053
Compare
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
ef14053 to
1d9abc5
Compare
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
1d9abc5 to
d5a066a
Compare
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
d5a066a to
271c12b
Compare
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
271c12b to
8881de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
ca1fb84,f94226a,341325f]:[email protected]
Patch Changes
#7508
ca1fb84Thanks @jnsdls! - properly type purchaseData#7521
f94226aThanks @joaquim-verges! - Add Frame wallet in wallet list#7523
341325fThanks @joaquim-verges! - Show all tokens in payment selection screen, even if not enough balance@thirdweb-dev/[email protected]
PR-Codex overview
This PR primarily focuses on updating the version numbers in various
package.jsonfiles, along with enhancing the changelogs forthirdweb,nebula, andwagmi-adapter. It includes several patch changes and minor improvements across different components.Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.105.5to5.105.6versioninpackages/nebula/package.jsonfrom0.2.5to0.2.6versioninpackages/wagmi-adapter/package.jsonfrom0.2.102to0.2.103CHANGELOG.mdforthirdwebwith new features and fixesCHANGELOG.mdfornebulawith updated dependencies.mdfiles from.changesetdirectorySummary by CodeRabbit
New Features
Bug Fixes
Chores