Version Packages #7577
Merged
Version Packages #7577
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update increments patch versions for the Changes
Sequence Diagram(s)Not applicable: The changes are limited to version bumps, changelog updates, and metadata removal, with no new or altered control flow. Possibly related PRs
Suggested labels
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
packages/thirdweb/package.json (1)
320-329: Missingsize-limitbudget despite having asizescriptThe coding guidelines for every
packages/*/package.jsonrequire bundle budgets to be declared via thesize-limitkey.
Right now the scriptsize: "size-limit"will run but has no config, so CI will silently succeed without guarding bundle size regressions.Suggested minimal fix:
"scripts": { ... "size": "size-limit", ... }, + "size-limit": [ + { + "path": "./dist/esm/exports/thirdweb.js", + "limit": "140 KB" + } + ],(Adjust the budget/entry-point to your real bundle target.)
packages/nebula/package.json (1)
46-56: Bundle size budget missing for Nebula as wellThis package has neither a
sizescript nor asize-limitsection, so bundle regressions won’t be caught.Quick win:
"scripts": { ... "lint": "biome check ./src" + ,"size": "size-limit" }, + "size-limit": [ + { "path": "./dist/esm/exports/thirdweb.js", "limit": "20 KB" } + ],Even a coarse limit provides immediate protection and can be tightened later.
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Add a brief entry under0.2.109
The new header has no content. Even a single line like “Patch-bump to keep versions in sync with workspace dependencies (thirdweb 5.105.12)” will help consumers understand why the release exists.packages/thirdweb/CHANGELOG.md (1)
3-8: Polish the changelog entry for clarity & inline‐code styleMinor wording and formatting tweaks will improve readability:
- - [#7575](https://github.com/thirdweb-dev/js/pull/7575) [`bfd728a`](https://github.com/thirdweb-dev/js/commit/bfd728a9d1aab7d0044791b218abf9ac9dbc9bf6) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Adds the ability to hide thirdweb branding in the payment widgets with showThirdwebBranding + - [#7575](https://github.com/thirdweb-dev/js/pull/7575) [`bfd728a`](https://github.com/thirdweb-dev/js/commit/bfd728a9d1aab7d0044791b218abf9ac9dbc9bf6) Thanks [@gregfromstl](https://github.com/gregfromstl)! – Adds the ability to hide thirdweb branding in payment widgets via the `showThirdwebBranding` optionReasons:
- Wrap the option name in back-ticks to denote inline code.
- Drop the definite article before “payment widgets” (concise).
- Use an en-dash to separate the commit citation from the description (consistent with many preceding entries).
Purely cosmetic—no functional impact, but improves professionalism.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/hip-mammals-sip.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/hip-mammals-sip.md
🧰 Additional context used
📓 Path-based instructions (1)
`packages/*/package.json`: Track bundle budgets via `package.json#size-limit` De-duplicate dependencies across packages through pnpm workspace hoisting
packages/*/package.json: Track bundle budgets viapackage.json#size-limit
De-duplicate dependencies across packages through pnpm workspace hoisting
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
packages/nebula/package.json (3)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
packages/wagmi-adapter/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
packages/nebula/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
packages/wagmi-adapter/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
packages/thirdweb/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/wagmi-adapter/package.json (1)
58-58: Version bump looks correct
0.2.109lines up with the changesets-driven release list and is consistent with the other package bumps in this PR.packages/thirdweb/package.json (1)
407-407: Patch-level version bump looks correct
"5.105.12"follows SemVer and matches the CHANGELOG entry, so no issues here.packages/nebula/package.json (1)
60-60: Patch-level version bump acknowledged
"0.2.12"is consistent with the linked changeset; nothing further to flag.packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry looks correct and well-formattedVersion header, semantic version bump, and dependency reference are all accurate and follow the existing style.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7577 +/- ##
==========================================
- Coverage 56.51% 56.49% -0.03%
==========================================
Files 906 906
Lines 57992 58028 +36
Branches 4223 4226 +3
==========================================
+ Hits 32777 32783 +6
- Misses 25107 25137 +30
Partials 108 108
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
bfd728a]:[email protected]
Patch Changes
bfd728aThanks @gregfromstl! - Adds the ability to hide thirdweb branding in the payment widgets with showThirdwebBranding@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers and changelogs across several packages, reflecting new releases and dependency updates.
Detailed summary
.changeset/hip-mammals-sip.md.versioninpackages/thirdweb/package.jsonfrom5.105.11to5.105.12.versioninpackages/nebula/package.jsonfrom0.2.11to0.2.12.versioninpackages/wagmi-adapter/package.jsonfrom0.2.108to0.2.109.## 0.2.12inpackages/nebula/CHANGELOG.mdwith dependency updates.## 5.105.12inpackages/thirdweb/CHANGELOG.mddetailing a new feature for hiding branding in payment widgets.Summary by CodeRabbit