feat(storage): support copying CSEK-encrypted files to non-CSEK destinations - #26
Open
thiyaguk09 wants to merge 6 commits into
Open
feat(storage): support copying CSEK-encrypted files to non-CSEK destinations#26thiyaguk09 wants to merge 6 commits into
thiyaguk09 wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for null encryption keys to allow copying CSEK-encrypted files to standard non-CSEK destinations. The review identifies a critical bug in the copy logic where the source file's encryption key is mutated and the destination file is left in an inconsistent state by bypassing setEncryptionKey. Feedback also suggests correcting the corresponding unit tests to avoid asserting on this buggy behavior and to use the proper setter method instead of manually assigning dummy properties.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
thiyaguk09
requested review from
gurusai-voleti,
mahendra-google and
shubhangi-google
June 29, 2026 11:52
shubhangi-google
approved these changes
Jun 29, 2026
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
2 times, most recently
from
July 10, 2026 12:30
76c3932 to
ea8daaa
Compare
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
5 times, most recently
from
July 27, 2026 06:48
a74b4bf to
657755f
Compare
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
7 times, most recently
from
August 4, 2026 06:08
c916584 to
6cb250f
Compare
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
5 times, most recently
from
August 6, 2026 03:36
d620144 to
c0104eb
Compare
🤖 I have created a release *beep* *boop* --- <details><summary>pack-n-play: 5.0.1</summary> ## [5.0.1](googleapis/google-cloud-node@pack-n-play-v5.0.0...pack-n-play-v5.0.1) (2026-08-05) ### Bug Fixes * **core:** Discovery url handling, error code review helper, and pack-n-play test timeouts ([googleapis#9061](googleapis#9061)) ([340364f](googleapis@340364f)) </details> <details><summary>gcp-metadata: 9.0.1</summary> ## [9.0.1](googleapis/google-cloud-node@gcp-metadata-v9.0.0...gcp-metadata-v9.0.1) (2026-08-05) ### Bug Fixes * **core:** Discovery url handling, error code review helper, and pack-n-play test timeouts ([googleapis#9061](googleapis#9061)) ([340364f](googleapis@340364f)) </details> <details><summary>googleapis-common: 9.0.1</summary> ## [9.0.1](googleapis/google-cloud-node@googleapis-common-v9.0.0...googleapis-common-v9.0.1) (2026-08-05) ### Bug Fixes * **core:** Discovery url handling, error code review helper, and pack-n-play test timeouts ([googleapis#9061](googleapis#9061)) ([340364f](googleapis@340364f)) </details> <details><summary>bigquery: 9.0.1</summary> ## [9.0.1](googleapis/google-cloud-node@bigquery-v9.0.0...bigquery-v9.0.1) (2026-08-05) ### Bug Fixes * **bigquery:** Remove owlbot configs ([googleapis#8936](googleapis#8936)) ([7f8e23c](googleapis@7f8e23c)) </details> <details><summary>bigtable: 7.1.0</summary> ## [7.1.0](googleapis/google-cloud-node@bigtable-v7.0.0...bigtable-v7.1.0) (2026-08-05) ### Features * **bigtable:** Split gapic and proto usage from the handwritten library into bigtable-api ([googleapis#8934](googleapis#8934)) ([f63f914](googleapis@f63f914)) </details> <details><summary>databasecenter: 0.4.1</summary> ## [0.4.1](googleapis/google-cloud-node@databasecenter-v0.4.0...databasecenter-v0.4.1) (2026-08-05) ### Bug Fixes * Upgrade types sinon for databasecenter ([googleapis#9098](googleapis#9098)) ([23aee11](googleapis@23aee11)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…apis#9099) Add Node.js 22 and pnpm v7 runtime setup steps to `.github/workflows/generation_check.yaml` prior to tool installation and generation verification. On default GitHub hosted CI runners (`ubuntu-latest`), `pnpm` is not pre-installed on the system `$PATH`, so executing `librarian install` immediately fails due to `exec: "pnpm": executable file not found in $PATH`.
…SEK and fix copy behavior for non-encrypted destinations
…r conflicts during file copy operations
…t instead of file request
…d fix system test service account binding
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
from
August 7, 2026 05:04
c0104eb to
a016a7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕