Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Rails 7.2 and Ruby 3.3 to testing matrix #1032

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hasghari
Copy link
Contributor

No description provided.

@hasghari hasghari requested a review from sej3506 as a code owner August 13, 2024 23:59
@hasghari hasghari force-pushed the intermittent-specs branch 4 times, most recently from edaee0c to 81017f8 Compare August 14, 2024 00:16
@hasghari hasghari marked this pull request as draft August 14, 2024 00:21
spec/dummy/application.rb Outdated Show resolved Hide resolved
@hasghari hasghari marked this pull request as ready for review August 14, 2024 00:46
@hasghari hasghari force-pushed the intermittent-specs branch 2 times, most recently from 6a3c5b9 to aa99de8 Compare August 14, 2024 01:16
@hasghari hasghari changed the title test: Commit lockfiles for consistent specs ci: Add Rails 7.2 and Ruby 3.3 to testing matrix Aug 14, 2024
.gitignore Show resolved Hide resolved
env["QUERY_STRING"] = Rack::Utils.build_query(params)
query_string = Rack::Utils.build_query(params)
env[Rack::QUERY_STRING] = query_string
env[Rack::RACK_REQUEST_QUERY_STRING] = query_string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the following deprecation warning:

warning: query string used for GET parsing different from current query string. Starting in Rack 3.2, Rack will used the cached GET value instead of parsing the current query string.

@hasghari hasghari force-pushed the intermittent-specs branch 2 times, most recently from 295b7eb to df45d05 Compare August 17, 2024 19:59
@hasghari hasghari force-pushed the intermittent-specs branch 2 times, most recently from 41e875c to 1046c53 Compare August 18, 2024 21:43
@sej3506
Copy link
Contributor

sej3506 commented Sep 12, 2024

There are a number of files deleted in this PR. Could you add a description and some information about what this PR is doing beyond updating the test matrix?

@hasghari
Copy link
Contributor Author

hasghari commented Sep 12, 2024

There are a number of files deleted in this PR. Could you add a description and some information about what this PR is doing beyond updating the test matrix?

@sej3506 Sure. I've tried to have descriptive commit messages for each of the 6 commits in this PR. However, the commit with the subject "Use default settings of Rails version under test" is the most substantial one. Many of the deprecation warnings that were produced were a result of testing different versions of Rails with non-default settings. My goal with that specific commit was to set config.load_defaults Rails::VERSION::STRING.to_f so that the default settings would be applied for testing the specific version of Rails under test.

I also wanted to standardize the setup of a dummy application for testing purposes so I generated the dummy application structure by copying the files generated by running rails plugin new. This ends up simplifying the configuration and removing some of the monkey-patching that was necessary in the old setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants