wrote a shakespeare analyzer #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaker, but was still making it print. I updated this so it makes more sense.
app.rb
Outdated
Contributor
There was a problem hiding this comment.
I'd probably extract this URL into a constant. I tend to do this for most "magic" values like this.
Contributor
There was a problem hiding this comment.
I doesn't look like @app needs to be an instance variable. I'd probably make it just a local if so.
Author
There was a problem hiding this comment.
Why should the URL be a constant?
The change I'm imagining would be
MACBETH_URL = "http://www.ibiblio.org/xml/examples/shakespeare/macbeth.xml"
HAMLET_URL = "http://www.ibiblio.org/xml/examples/shakespeare/hamlet.xml"
macbeth_analyzer = ShakespeareAnalyzer.new MACBETH_URL
hamlet_analyzer = ShakespeareAnalyzer.new HAMLET_URLI guess I don't see the value.
Contributor
|
Good effort! I left some comments inline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.