chore(test): drop duplicate S3_REGION assignments in env config tests - #1447
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (6)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesEnvironment configuration tests
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#1433 and #1434 landed the same fix independently (two sessions racing to unbreak main after #1387 merged with a red run). The four
github app configurationproduction tests inapps/backend/src/lib/env.test.tsnow setS3_REGIONtwice each.Harmless, four redundant lines.
Solution
Drop the second assignment in each block. Kept the one that sits with the other production prerequisites right after
NODE_ENV = "production", rather than the one stranded betweenWORKOS_COOKIE_PASSWORDandGITHUB_APP_ID.Files changed
apps/backend/src/lib/env.test.tsS3_REGIONassignments removedTest plan
bun test src/lib/env.test.ts— 30 pass, 0 fail (with the stray localapps/backend/.envmoved aside, which otherwise shadowsloadConfigtests)🤖 PR by Claude Code