Skip to content

chore(test): drop duplicate S3_REGION assignments in env config tests - #1447

Merged
kristofferremback merged 1 commit into
mainfrom
chore/env-test-s3-region-dedupe
Jul 20, 2026
Merged

chore(test): drop duplicate S3_REGION assignments in env config tests#1447
kristofferremback merged 1 commit into
mainfrom
chore/env-test-s3-region-dedupe

Conversation

@kristofferremback

@kristofferremback kristofferremback commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Problem

#1433 and #1434 landed the same fix independently (two sessions racing to unbreak main after #1387 merged with a red run). The four github app configuration production tests in apps/backend/src/lib/env.test.ts now set S3_REGION twice each.

Harmless, four redundant lines.

Solution

Drop the second assignment in each block. Kept the one that sits with the other production prerequisites right after NODE_ENV = "production", rather than the one stranded between WORKOS_COOKIE_PASSWORD and GITHUB_APP_ID.

Files changed

File Change
apps/backend/src/lib/env.test.ts 4 duplicate S3_REGION assignments removed

Test plan

  • bun test src/lib/env.test.ts — 30 pass, 0 fail (with the stray local apps/backend/.env moved aside, which otherwise shadows loadConfig tests)

🤖 PR by Claude Code

#1433 and #1434 landed the same fix independently, so the four github
production blocks set S3_REGION twice each. Keeps the assignment that sits
with the other production prerequisites.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a698ef95-95c9-4730-89dd-161f37e9b68e

📥 Commits

Reviewing files that changed from the base of the PR and between b3661b6 and f0f520e.

📒 Files selected for processing (1)
  • apps/backend/src/lib/env.test.ts
💤 Files with no reviewable changes (1)
  • apps/backend/src/lib/env.test.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout. (6)
  • GitHub Check: browser-tests (3)
  • GitHub Check: browser-tests (1)
  • GitHub Check: browser-tests (4)
  • GitHub Check: browser-tests (2)
  • GitHub Check: Typecheck
  • GitHub Check: Tests

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Removed redundant test environment setup in GitHub app configuration tests.
    • Existing assertions and configuration-loading behavior remain unchanged.

Walkthrough

Changes

Environment configuration tests

Layer / File(s) Summary
Remove redundant test setup
apps/backend/src/lib/env.test.ts
Four production GitHub configuration tests no longer repeat the S3_REGION assignment; assertions and loadConfig() flows are unchanged.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the actual change: removing duplicate S3_REGION assignments from env config tests.
Description check ✅ Passed The description accurately describes the same test cleanup and includes relevant context and test results.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@kristofferremback
kristofferremback marked this pull request as ready for review July 20, 2026 10:35
@kristofferremback
kristofferremback merged commit 89d58e4 into main Jul 20, 2026
15 checks passed
@kristofferremback
kristofferremback deleted the chore/env-test-s3-region-dedupe branch July 20, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant