Rate limiter for the grid-proxy #1385
Open
+611
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nabil salah <[email protected]>
Nabil-Salah
requested review from
AbdelrahmanElawady,
Eslam-Nawara,
Omarabdul3ziz,
ashraffouda,
mariobassem,
rawdaGastan,
sameh-farouk and
xmonader
as code owners
Signed-off-by: nabil salah <[email protected]>
Nabil-Salah
force-pushed
the
development_proxy_ratelimiter
branch
from
3f1d504 to
7ec4aea
Compare
Member
There was a problem hiding this comment.
Should we first consider using our reverse-proxy rate limiter? Since it’s a simple IP-based limiter that doesn’t require any business logic, configuring it properly could reduce application complexity and is often more reliable than implementing custom rate-limiting code for such a common use case.
That said, I’m also wondering whether this has been tested behind a reverse proxy. The way GetClientIP parses headers may cause all users to be grouped under the same IP address (depending on how the reverse proxy is configured).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes introduced by this PR and what does it affect
Changes
List of changes this PR includes
Related Issues
Checklist