Skip to content

Enhance SignUpButton and SignInButton components in Vue - #64

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:main
Aug 11, 2026
Merged

Enhance SignUpButton and SignInButton components in Vue#64
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:main

Conversation

@brionmario

Copy link
Copy Markdown
Member

Purpose

Enhance the SignUpButton component with an asChild prop for custom rendering. Adjust the SignInButton usage in Vue samples to support this new prop. Update README files to clarify credential setup for various samples and remove unnecessary configuration files and environment variables from the samples.

Approach

Implement the asChild prop in the SignInButton component to allow for custom button rendering. Clean up sample configurations and environment files across all frameworks to streamline the setup process.

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@brionmario, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b8ccf43c-a68a-464e-ab3f-43d4e746e20a

📥 Commits

Reviewing files that changed from the base of the PR and between 5a7cc88 and e498b6b.

📒 Files selected for processing (30)
  • packages/vue/src/__tests__/components/actions.test.ts
  • packages/vue/src/components/actions/SignInButton.ts
  • packages/vue/src/components/actions/SignUpButton.ts
  • samples/browser/quickstart/README.md
  • samples/browser/quickstart/thunderid-config/thunderid-config.yaml
  • samples/browser/quickstart/thunderid-config/thunderid.env
  • samples/express/quickstart/README.md
  • samples/express/quickstart/thunderid-config/thunderid-config.yaml
  • samples/express/quickstart/thunderid-config/thunderid.env
  • samples/nextjs/quickstart/.env.example
  • samples/nextjs/quickstart/README.md
  • samples/nextjs/quickstart/scripts/prepare-dev.cjs
  • samples/nextjs/quickstart/thunderid-config/thunderid-config.yaml
  • samples/nextjs/quickstart/thunderid-config/thunderid.env
  • samples/node/quickstart/.env.example
  • samples/node/quickstart/README.md
  • samples/node/quickstart/lib/ui.mjs
  • samples/nuxt/quickstart/.env.example
  • samples/nuxt/quickstart/README.md
  • samples/nuxt/quickstart/scripts/prepare-dev.cjs
  • samples/nuxt/quickstart/thunderid-config/thunderid-config.yaml
  • samples/nuxt/quickstart/thunderid-config/thunderid.env
  • samples/react/quickstart/README.md
  • samples/react/quickstart/thunderid-config/thunderid-config.yaml
  • samples/react/quickstart/thunderid-config/thunderid.env
  • samples/vue/quickstart/README.md
  • samples/vue/quickstart/src/components/Nav.vue
  • samples/vue/quickstart/src/pages/HomePage.vue
  • samples/vue/quickstart/thunderid-config/thunderid-config.yaml
  • samples/vue/quickstart/thunderid-config/thunderid.env
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch main
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

docs: update README files to clarify credential setup for various samples

refactor: remove thunderid-config files and environment variables from samples

fix: adjust SignInButton usage in Vue samples for asChild prop

chore: clean up sample configurations and environment files across all frameworks
@brionmario brionmario changed the title Enhance SignUpButton and SignInButton components, update documentation Enhance SignUpButton and SignInButton components in Vue Aug 11, 2026
@brionmario
brionmario merged commit d1e53ef into thunder-id:main Aug 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants