Better Auth community helper for ThunderID - #90
Closed
brionmario wants to merge 1 commit into
Closed
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brionmario
added a commit
to brionmario/better-auth
that referenced
this pull request
Sep 2, 2026
Adds ThunderID to the Community Provider Helpers table for the Generic OAuth plugin, per better-auth#11059. The @thunderid/better-auth package returns a typed GenericOAuthConfig for a ThunderID issuer; all OAuth 2.0 / OIDC handling is performed by Better Auth itself. Related: thunder-id/thunderid#3559 See: thunder-id/javascript-sdks#90 Signed-off-by: Brion <info@brionmario.com>
Better Auth community helper for ThunderID
brionmario
force-pushed
the
feat/better-auth-provider-helper
branch
from
September 4, 2026 06:39
02c4f2f to
ea4081b
Compare
12 tasks
brionmario
force-pushed
the
feat/better-auth-provider-helper
branch
from
September 4, 2026 07:06
ea4081b to
9c1014d
Compare
Introduces @thunderid/better-auth, a community provider helper that returns a typed GenericOAuthConfig for a ThunderID issuer to use with Better Auth's generic-oauth plugin. All OAuth 2.0 / OIDC handling is performed by Better Auth itself, so there is no ThunderID SDK dependency or protocol logic to keep in sync. The callback route registered with ThunderID is /callback/:providerId, not /oauth2/callback/:providerId, matching the Generic OAuth plugin's core callback route (verified against a running sample app sign-in). Related: thunder-id/thunderid#3559 Signed-off-by: Brion <info@brionmario.com>
brionmario
force-pushed
the
feat/better-auth-provider-helper
branch
from
September 4, 2026 07:58
9c1014d to
62781c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds
@thunderid/better-auth, a community provider helper for Better Auth's Generic OAuth plugin. It returns a typedGenericOAuthConfigfor a ThunderID issuer, so a Better Auth app can sign users in through ThunderID without any first-class provider support in Better Auth itself.This follows the approach requested by the Better Auth maintainers after better-auth/better-auth#10237 (a first-class
generic-oauthprovider export) was declined per their social provider integration policy — they asked for a community provider helper package instead, to be listed in their docs.Approach
thunderid()only supplies configuration — the callback route, discovery URL derivation, and scopes — for Better Auth'sgeneric-oauthplugin. All OAuth 2.0 / OIDC handling (authorization, token exchange, callback handling) is performed by Better Auth itself, so there is no ThunderID SDK dependency or protocol logic to keep in sync.The callback route registered with ThunderID is
/callback/:providerId, not/oauth2/callback/:providerId— this matches the Generic OAuth plugin's actual core callback route, verified against a running sample app sign-in.Related Issues
Better Authprovider thunderid#3559Related PRs
Checklist
breaking changelabel added.Security checks