Add npm vulnerability skills, fix qs advisories - #91
Merged
Conversation
Signed-off-by: Brion <info@brionmario.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Brion <info@brionmario.com>
brionmario
force-pushed
the
fix-npm-vulnerabilities
branch
from
September 3, 2026 10:02
9fec784 to
72ff703
Compare
rajithacharith
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add two agent skills that codify how we handle pnpm/npm security advisories in this monorepo:
Fix npm Vulnerability(update the head dependency, or fall back to a scopedpnpm-workspace.yamloverride with a tracking GitHub issue) and
Prune npm Overrides(audit existing overrides and removeones upstream has since fixed). AGENTS.md is updated to list both under a new "Skills" section.
As a concrete instance of the first skill, this PR also applies it to fix two live advisories:
GHSA-x5fp-wj9c-mxmx (array-limit bypass via bracket-key comma parsing) and GHSA-4mjr-xmp4-gh2g (DoS via
attacker-controlled
isBuffer) inqs, transitive viabody-parser's ownqs: ~6.15.1range. Thatrange caps at 6.15.3 and the patched 6.15.4 was never published upstream, so the override jumps straight
to 6.16.0.
Approach
.agent/skills/fix-npm-vulnerability/SKILL.md— new skill, invoked whenpnpm auditor Dependabotsurfaces an advisory. Tries updating the head dependency first; falls back to a scoped override plus a
tracking issue when the fix isn't released upstream yet.
.agent/skills/prune-npm-overrides/SKILL.md— new skill for periodically reviewingpnpm-workspace.yamloverrides and dropping the ones no longer needed.AGENTS.md— documents both skills under a new "Skills" section.pnpm-workspace.yaml— adds thebody-parser>qs: 6.16.0override (scoped, since it's only reachablethrough
body-parser), following the format the fix-npm-vulnerability skill produces.package.json— bumps the pinnedpnpmdevEnginesversion to 11.25.0.pnpm-lock.yaml— regenerated after the override and pnpm bump.Related Issues
npmvulnerabilities thunderid#5263Related PRs
Checklist
breaking changelabel added.Security checks