ThunderID helper for Better Auth (@thunderid/better-auth) - #93
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brionmario
force-pushed
the
better-auth
branch
2 times, most recently
from
September 4, 2026 10:09
956861a to
0ed17b3
Compare
Introduces @thunderid/better-auth, a community provider helper that returns a typed GenericOAuthConfig for a ThunderID issuer to use with Better Auth's generic-oauth plugin. All OAuth 2.0 / OIDC handling is performed by Better Auth itself, so there is no ThunderID SDK dependency or protocol logic to keep in sync. The callback route registered with ThunderID is /callback/:providerId, not /oauth2/callback/:providerId, matching the Generic OAuth plugin's core callback route (verified against a running sample app sign-in). Related: thunder-id/thunderid#3559 Signed-off-by: Brion <info@brionmario.com>
brionmario
force-pushed
the
better-auth
branch
from
September 4, 2026 10:38
0ed17b3 to
e19c6a4
Compare
@thunderid/better-auth)
DonOmalVindula
approved these changes
Sep 4, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduces @thunderid/better-auth, a community provider helper that returns a typed GenericOAuthConfig for a ThunderID issuer to use with Better Auth's generic-oauth plugin.
Approach
All OAuth 2.0 / OIDC handling is performed by Better Auth itself, so there is no ThunderID SDK dependency or protocol logic to keep in sync.
The callback route registered with ThunderID is /callback/:providerId, not /oauth2/callback/:providerId, matching the Generic OAuth plugin's core callback route (verified against a running sample app sign-in).
Related Issues
Better Authprovider thunderid#3559Related PRs
Checklist
breaking changelabel added.Security checks