Skip to content

ThunderID helper for Better Auth (@thunderid/better-auth) - #93

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:better-auth
Sep 4, 2026
Merged

ThunderID helper for Better Auth (@thunderid/better-auth)#93
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:better-auth

Conversation

@brionmario

@brionmario brionmario commented Sep 4, 2026

Copy link
Copy Markdown
Member

Purpose

Introduces @thunderid/better-auth, a community provider helper that returns a typed GenericOAuthConfig for a ThunderID issuer to use with Better Auth's generic-oauth plugin.

Approach

All OAuth 2.0 / OIDC handling is performed by Better Auth itself, so there is no ThunderID SDK dependency or protocol logic to keep in sync.

The callback route registered with ThunderID is /callback/:providerId, not /oauth2/callback/:providerId, matching the Generic OAuth plugin's core callback route (verified against a running sample app sign-in).

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 7643a376-5231-4b49-9f56-b2f1dfa837ac


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brionmario
brionmario force-pushed the better-auth branch 2 times, most recently from 956861a to 0ed17b3 Compare September 4, 2026 10:09
Introduces @thunderid/better-auth, a community provider helper that returns a
typed GenericOAuthConfig for a ThunderID issuer to use with Better Auth's
generic-oauth plugin. All OAuth 2.0 / OIDC handling is performed by Better
Auth itself, so there is no ThunderID SDK dependency or protocol logic to
keep in sync.

The callback route registered with ThunderID is /callback/:providerId, not
/oauth2/callback/:providerId, matching the Generic OAuth plugin's core
callback route (verified against a running sample app sign-in).

Related: thunder-id/thunderid#3559

Signed-off-by: Brion <info@brionmario.com>
@brionmario brionmario changed the title Add ThunderID provider helper for Better Auth's Generic OAuth plugin ThunderID for Better Auth Sep 4, 2026
@brionmario brionmario changed the title ThunderID for Better Auth ThunderID helper for Better Auth (@thunderid/better-auth) Sep 4, 2026
@brionmario
brionmario merged commit 837f303 into thunder-id:main Sep 4, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants