Align dbscripts directory names with database names using underscores - #4164
Conversation
The dbscripts schema directories used kebab-case (runtime-transient, runtime-persistent) while the Postgres database names and config keys use underscores (runtime_transient, runtime_persistent). Because the two forms differed, the Helm quickstart schema-apply loop resolved directory paths that do not exist and silently left those two databases empty. Rename the two dbscripts directories and their SQLite files to underscores so the directory name matches the database name and config key for all four databases, and update every reference: build scripts, integration test config, Helm and OpenChoreo charts, the local-development compose source paths, the integration-test CI action, and the documentation (developer docs, deployment guides, Helm and OpenChoreo READMEs, the db skill guide, and the architecture overview). Kubernetes Secret data keys, the container-internal compose mount aliases, and prose references to the databases keep their kebab-case names, as those belong to separate naming domains. Fixes thunder-id#4120
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Purpose
The
backend/dbscripts/schema directories used kebab-case names (runtime-transient,runtime-persistent) while the Postgres database names and the config keys use underscores (runtime_transient,runtime_persistent).Because the two forms differed, the Helm quickstart schema-apply loop, which reuses the database name as the directory path, resolved
dbscripts/runtime_transient/which does not exist. The failure was silent:caterrored to stderr whilepsqlexited 0 on empty input, so the two runtime databases were left with zero tables and no error was reported.This aligns the physical artifact names to underscores so the directory name equals the database name and the config key for all four databases, removing the mismatch at its source. Documentation references are updated in the same PR.
🔧 Summary of Breaking Changes
The two runtime
dbscripts/directories and their SQLite files are renamed:dbscripts/runtime-transient/todbscripts/runtime_transient/dbscripts/runtime-persistent/todbscripts/runtime_persistent/runtime-transient.db/runtime-persistent.dbtoruntime_transient.db/runtime_persistent.dbPostgres database names and config keys are unchanged (already underscore).
💥 Impact
Existing SQLite deployments that use the default paths
database/runtime-transient.dbanddatabase/runtime-persistent.dbwill, after this change, look for the underscore file names and create fresh empty databases if the old files are not renamed. Anyone applying schemas from an olddbscripts/checkout by the kebab directory name must use the underscore names.🔄 Migration Guide
For SQLite, rename the existing data files to
runtime_transient.dbandruntime_persistent.db, or point the configured paths at the old files. Postgres deployments need no change; the database names were alreadyruntime_transientandruntime_persistent.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks