Add SSO support to the Wayfinder sample authentication flow - #4683
Add SSO support to the Wayfinder sample authentication flow#4683Dilusha-Madushan wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Wayfinder authentication configurations now check for an existing SSO session before prompting for credentials. Successful SSO and credential authentication pass through session handling before authorization. ChangesWayfinder authentication flow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Purpose
The Wayfinder sample's authentication flow (
wayfinder-app-auth-flow) had no SSOhandling, so every authorization request landed on the credentials prompt even when
the user already had a valid session. This PR adds SSO support to that flow, bringing
the sample in line with the default Console app authentication flow.
Scope is limited to
wayfinder-app-auth-flowin the two Wayfinder sampleconfigurations (
redirectandapp-native). The registration, recovery, CIBA email,CIBA SMS, and agent authentication flows are unchanged.
Approach
Two nodes were added to the flow:
sso_check(SSOCheckExecutor), inserted betweenstartand the credentialsprompt. It declares
checkpointRef: session, so on a session hit the flow jumpsstraight to the session join node, and on a miss
onFailurefalls through toprompt_credentials.session(SessionExecutor), inserted as the join node beforeauthorization_check.credentials_auth.onSuccessnow targets it instead ofauthorization_check, so both the SSO path and the interactive login pathconverge on the same node before authorization.
Related Issues
Summary by CodeRabbit
New Features
Bug Fixes