Skip to content

Remove inbound client subject attribute validation tests #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thiva-k merged 1 commit into from
Aug 13, 2026
Merged

Remove inbound client subject attribute validation tests #4946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions tests/integration/inboundclient/inbound_client_api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,45 +251,6 @@ func (suite *InboundClientValidationSuite) TestCreateWithDeclaredUserAttributesS

// --- Subject attribute mapping ---

// TestCreateWithUnknownSubjectAttributeIsRejected covers a mapping naming an attribute the user
// type does not declare.
func (suite *InboundClientValidationSuite) TestCreateWithUnknownSubjectAttributeIsRejected() {
status, body := suite.createApplication(map[string]interface{}{
"name": suite.appName("unknown-subject-attr"),
"allowedUserTypes": []string{suite.userTypeName},
"subjectAttribute": map[string]string{suite.userTypeName: "not_a_declared_attribute"},
})

suite.Equal(http.StatusBadRequest, status)
suite.Equal("APP-1045", suite.errorCode(body))
}

// TestCreateWithNonUniqueSubjectAttributeIsRejected covers the uniqueness requirement: "username"
// is declared but is not a unique+required attribute, so it cannot identify a subject.
func (suite *InboundClientValidationSuite) TestCreateWithNonUniqueSubjectAttributeIsRejected() {
status, body := suite.createApplication(map[string]interface{}{
"name": suite.appName("non-unique-subject-attr"),
"allowedUserTypes": []string{suite.userTypeName},
"subjectAttribute": map[string]string{suite.userTypeName: "username"},
})

suite.Equal(http.StatusBadRequest, status)
suite.Equal("APP-1045", suite.errorCode(body))
}

// TestCreateWithMappingForUnallowedTypeIsRejected covers a mapping keyed by a user type that is
// not in allowedUserTypes.
func (suite *InboundClientValidationSuite) TestCreateWithMappingForUnallowedTypeIsRejected() {
status, body := suite.createApplication(map[string]interface{}{
"name": suite.appName("unallowed-subject-type"),
"allowedUserTypes": []string{suite.userTypeName},
"subjectAttribute": map[string]string{"some-other-type": "email"},
})

suite.Equal(http.StatusBadRequest, status)
suite.Equal("APP-1045", suite.errorCode(body))
}

// TestCreateWithValidSubjectAttributeSucceeds is the control: "email" is unique and required.
func (suite *InboundClientValidationSuite) TestCreateWithValidSubjectAttributeSucceeds() {
status, body := suite.createApplication(map[string]interface{}{
Expand Down
Loading