Handle incompatible yq implementations - #5253
Conversation
Fixes thunder-id#5216 Signed-off-by: ZiyamSanthosh <santhoshziyam@gmail.com>
9c660da to
94284e1
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Changesyq validation fallback
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The scripts now reject incompatible yq implementations and use the existing fallback parser, preserving configuration parsing without introducing an actionable merge-blocking risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Purpose
Prevent
setup.shandbuild.shfrom terminating when an incompatibleyqimplementation is present inPATH.Fixes #5216
Approach
yqsupports the requiredevalsyntax before using it.Related Issues
Related PRs
Checklist
breaking changelabel added.Validation
bash -n setup.sh build.shgit diff --checkyq3.1.0, which is rejected and therefore selects the existing fallback.Security checks
Summary by CodeRabbit
yqtool is unavailable or not functioning correctly.