[1.0.x → main] Prepare branch for the pinned-commit release builder (#5273) - #5280
Draft
thunder-automation-bot wants to merge 1 commit into
Draft
[1.0.x → main] Prepare branch for the pinned-commit release builder (#5273)#5280thunder-automation-bot wants to merge 1 commit into
thunder-automation-bot wants to merge 1 commit into
Conversation
Signed-off-by: Osara-B <osara922@gmail.com>
|
👋 @Osara-B @rajithacharith please review this forward-port of #5273 to
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated forward-port of #5273 from
1.0.xtomain.Original PR: #5273
Commits cherry-picked: 1
Source branch:
1.0.xTarget branch:
mainPurpose
The release builder is being reworked so a release can be built and verified from any branch (#4981). It pins the source branch to a single immutable commit and checks that same commit out in every job, which means the files it reads at release time come from the branch being released rather than from the branch the workflow was dispatched from.
The files in this PR are read that way, so they have to be correct here before a release can be cut from this branch. This PR brings them in ahead of the workflow change on
main.The integration test action also fixes a live bug on this branch. It checks out a ref of its own, which replaces
$GITHUB_WORKSPACEin the middle of the job and discards whatever the caller had checked out. On this branch the release builder checks outRELEASE_BRANCHand the action then reverts the workspace to the dispatched ref, so the integration suite can run against different sources than the ones the distribution under test was built from.Approach
Removed the
actions/checkoutstep from.github/actions/run-integration-tests. Composite actions resolve out of$GITHUB_WORKSPACE, so a checkout inside one can silently swap the tree the rest of the job runs against. All three callers on this branch (pr-builder.yml,postgres-tests.ymlandrelease-builder.yml) already check out the sources themselves before invoking the action, so nothing changes on the calling side.Added a guard so the action skips its artifact download when the caller has already staged a distribution in
target/dist.Added
.github/docker/Dockerfile.release, which assembles the container image by unzipping the already published Linux archives instead of recompiling the product insidedocker buildx. Extraction happens on$BUILDPLATFORMto avoid QEMU emulation, and the twodeployment.yamledits are applied to the packaged file rather than to the source tree.The root
Dockerfileis functionally unchanged and still builds from source formake docker-build*. It gains a comment naming the release Dockerfile, because the two share a runtime stage that has to be kept in sync.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks