test(ledger): enforce 90% domain coverage gate - #149
Merged
Conversation
Wire jacocoTestCoverageVerification scoped to com.fincore.ledger.domain only, reading the unit test exec data (Docker-free), bound to check via dependsOn so it is not opt-in. LINE and BRANCH floors at 0.90; excludes generated mappers and config. Close the residual gap with DomainExceptionsTest (every domain exception ctor plus the DomainException blank-message guard, both paths) and add the three audit enums to EnumSanityTest. Domain bundle measures 100% line and branch. Closes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wires a JaCoCo coverage-verification gate scoped to
com.fincore.ledger.domainand closes the residual domain test gap.jacocoTestCoverageVerificationmeasures onlycom.fincore.ledger.domain.**, reading the fast unittestexec data (no Docker / no integrationTest), bound tocheckviadependsOnso it is not opt-in. Excludes**/*MapperImpl*and**/config/**.DomainExceptionsTest(new): constructs everydomain/exception/*type and drives theDomainExceptionblank-messagerequireon both paths.EnumSanityTest: addedAuditAction/AuditResult/AuditResourceType(they live underdomain.enum, so they are in the gate bundle).Evidence
Domain bundle measured LINE 123/123 = 1.000, BRANCH 47/47 = 1.000 (non-vacuous). Local gate green: test + jacocoTestCoverageVerification + detekt + spotlessCheck + assemble.
jacocoTestCoverageVerificationconfirmed in the:services:ledger:checktask graph.Gates
critic GO-WITH-CHANGES (3 audit enums folded), code-reviewer APPROVE-WITH-NITS (folded), evaluator 0.95, security-auditor PASS.
Closes #53