feat(sandbox): add the payments service to docker-compose - #241
Merged
Conversation
Parameterize the root Dockerfile with ARG SERVICE so the same build produces either service jar (default ledger keeps the image CI job and the ledger build unchanged). Add a payments service on host port 8081 pointing at its own payments database, created by a postgres initdb script so each service owns its Liquibase changelog. Enable the sandbox bank provider so payments boots without a real adapter. Genericize the smoke script and poll both services in compose-smoke. Closes #238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the payments service to the local sandbox compose stack (E-06, #238).
What
DockerfilewithARG SERVICE=ledgerso the same multi-stage build produces either service jar. Defaultledgerkeeps the ledger build and the docker image CI job unchanged.paymentsservice todocker-compose.ymlon host port 8081, pointing at its ownpaymentsdatabase,depends_onpostgres healthy, with the sandbox bank provider enabled (FINCORE_PAYMENTS_BANK_SANDBOX_ENABLED=true) so it boots without a real adapter.scripts/initdb/01-create-payments-db.sql) so each service keeps an isolated LiquibaseDATABASECHANGELOG/lock.scripts/demo.shwording so it smoke-checks any base URL (behaviour identical for ledger).compose-smokeCI job now polls both 8080 (ledger) and 8081 (payments), preserving the load-bearing step order.Notes
PaymentWebhookPropertiesdefaults to a blank fail-closed secret, so payments boots fine and no weak secret is committed.docker compose configcould not run. The CI Compose smoke job is the binding verification: payments must come up on 8081.Gate chain
Closes #238