feat(observability): add prometheus alert rules with slo burn-rate - #260
Merged
Conversation
Add P0-P3 alerting rules loaded by the observability-profile Prometheus: an instance-down page, multi-window multi-burn-rate alerts on the 5xx error budget (fast and slow), a p95 request-latency alert, and a target-flapping warning. The rules reference the metrics the services already emit and are validated in CI by promtool (check config and check rules) against the pinned Prometheus image. Closes #252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Prometheus alerting rules as code, the final E-07 slice (#252).
What
deploy/observability/alerts.ymlwith 5 rules across P0-P3:up == 0.http_server_requests_seconds_countonly (no fragile fixed-lebucket dependency); NaN-safe when idle.histogram_quantile(0.95, ...)> 0.5s.changes(up[15m]) >= 4.prometheus.ymlreferences the rules viarule_files; the profiled Prometheus mountsalerts.yml.check configandcheck rulessteps) via the pinnedprom/prometheus:v2.55.1image, triggered on PR and push fordeploy/observability/**.Notes
Alertmanager/notification routing is out of scope - the rules load into Prometheus and are visible at
/alerts.Gate chain
Closes #252