feat(sandbox): drive the full payment lifecycle in the compose smoke - #320
Merged
Conversation
Add a demo that exercises a payment end to end against the sandbox: it obtains a client-credentials token, initiates a payment, waits for it to reach SUBMITTED on its own, then delivers an HMAC-signed webhook and asserts the payment settles. The webhook secret is wired into the payments service, the signature is computed in-script over the exact posted body, and the compose smoke runs the journey so a regression in orchestration or webhook verification fails CI. Secrets come from the environment with documented sandbox defaults. Closes #236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-06.5 (#236) - end-to-end payment lifecycle demo, run in the compose smoke. Unblocked by #315 (Keycloak in the sandbox) and #317 (automatic orchestration after initiate).
What
scripts/demo-payment.sh drives the full journey against the live stack:
Wires FINCORE_PAYMENTS_WEBHOOK_HMACSECRET into the payments service (compose) and the compose-smoke job; the CI runs the demo after the auth-chain proof. So a regression in orchestration or webhook verification now fails CI - the demo doubles as a regression test (it is exactly what would have caught the #317 defect).
Source-fidelity
Gate chain
critic: initially NO-GO - it correctly caught that the branch was stale (reused a pre-existing branch based on main BEFORE #317 merged, so the orchestration code was absent). Fixed by rebranching from current main; #317 verified present. All other items the critic had already verified. code-reviewer: applied uuidgen portability; -d args already quoted; explicit CI env added. security-auditor (opus): PASS (6/6 ACs, HMAC parity exact, secret wiring matches, webhook permitAll, no publish, clean-room). evaluator: PASS (0.91).
Closes #236