fix(payments): recover stuck initiated payments in the retry sweep - #321
Merged
Conversation
The retry sweep previously only re-routed payments stuck in SCREENING. A crash between an initiate commit and the after-commit orchestration could leave a payment stranded in INITIATED with nothing to advance it. Sweep both states through a shared loop: stuck INITIATED payments are orchestrated from the start, stuck SCREENING payments are resumed, and either is failed once past the deadline. Closes #318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#318 - durability backstop for #317.
A crash between an initiate commit and the after-commit @async orchestration could leave a payment stranded in INITIATED with nothing to advance it (the sweep previously only handled SCREENING). Now retryStuck() sweeps both states via a shared loop: stuck INITIATED -> orchestrator.process (INITIATED -> SCREENING -> submit), stuck SCREENING -> resume, either past the deadline -> markFailed. SCREENING behaviour is preserved.
Tests
PaymentRetryServiceTest extended with per-status stubbing and INITIATED cases (within-window -> process, no resume/markFailed; past-deadline -> markFailed, no process/resume); the three SCREENING tests are unchanged. detekt + spotless + unit tests green locally.
Gate chain
code-reviewer: APPROVED after one must-fix applied (added a resume cross-call guard to the INITIATED-deadline test). evaluator: PASS (0.89). The unbounded sweep query is a pre-existing concern (it predates this change on the SCREENING path) and is left as a follow-up.
Closes #318