Skip to content

docs: correct and complete the README - #325

Merged
tiana-code merged 1 commit into
mainfrom
feat/readme-accuracy
Jun 20, 2026
Merged

docs: correct and complete the README#325
tiana-code merged 1 commit into
mainfrom
feat/readme-accuracy

Conversation

@tiana-code

Copy link
Copy Markdown
Owner

Corrects factual drift in README.md, verified claim-by-claim against the repo.

What changed

  • Quick start: replaced the non-existent deploy/docker-compose.yml path with docker compose up -d (compose lives at the repo root), and documented the scripts/fincore helper (init/status/run-demo) plus the real service ports.
  • Infrastructure list: the sandbox stack is postgres, keycloak, ledger (:8080), payments (:8081), web (:8082). Removed Redpanda/Redis, which the compose stack does not run; the broker is described accurately as a production option.
  • Repository layout: synced with the real tree (libs/{fincore-eventbus,fincore-observability,decision-engine,sdk-kotlin}, sdk/typescript, examples/, web/, root docker-compose.yml).
  • Architecture diagram: removed the API Gateway node (no gateway service exists); clients call each service directly.
  • Developer experience: new section covering the Kotlin and TypeScript SDKs, the fincore CLI, runnable examples, and the Bruno API collection.

Verification

Every claim fact-checked against the filesystem and docker-compose.yml (code-reviewer gate: PASS). No em/en-dash, no AI-tells.

The quick start pointed at a non-existent deploy/docker-compose.yml and
listed brokers the sandbox stack does not run. Sync every claim with the
real repo: compose at the root, the actual service set and ports, the
current libs/sdk/examples/web layout, a gateway-free architecture diagram,
and a Developer experience section covering the SDKs, CLI, examples, and
API collection.
@tiana-code
tiana-code merged commit 37004db into main Jun 20, 2026
8 checks passed
@tiana-code
tiana-code deleted the feat/readme-accuracy branch June 20, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant