refactor: trim restating comments and tighten test variable names - #329
Merged
Conversation
Cut the docstrings that only restated adjacent code, the sandbox provider doc blocks foremost, and trimmed the verbose ones down to the non-obvious why. Comments that carry a real invariant (transaction boundary, fail-closed, concurrency, MapStruct limits, privacy) stay, and the public plug-in port contracts keep their documentation. Renamed the single-letter locals in the domain and mapper tests to descriptive names. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full code-quality pass requested by the owner, covering comments, naming, and structure.
Findings
@Transactional, interface + impl services, DTOs split into request/response, enums underdomain/enum, repositories ininfrastructure). Nothing to change.c/s/atocase/session/alert, anda/btodebitAccount/creditAccount).Comment changes (balanced bar)
whenblock already shows), plus a handful of restating one-liners.17 files, comments and test names only, no behavior change. Verified: all four services compile; compliance/ledger/decision unit tests green (466 total); spotless and detekt clean. Integration tests run on CI (need Docker).