lift Repeat out of the base alert config #716
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds on #715 |
toddkazakov
approved these changes
May 28, 2024
ewollesen
force-pushed
the
eric-cpa-alerts
branch
from
374bae2 to
2deda23
Compare
ewollesen
force-pushed
the
eric-cpa-alerts2
branch
from
10757d8 to
e926564
Compare
ewollesen
force-pushed
the
eric-cpa-alerts
branch
from
2deda23 to
8549c33
Compare
ewollesen
force-pushed
the
eric-cpa-alerts2
branch
from
e926564 to
12cee7d
Compare
The Get endpoint already exists on the service, so only the List endpoint needed to be added there. BACK-2554
ewollesen
force-pushed
the
eric-cpa-alerts
branch
from
8549c33 to
8367902
Compare
Through discussions it was confirmed that Repeat is not universal to all alerts. So it's lifted out of the Base alert and re-inserted into those alerts where it should be present (namely Low and High alerts only). BACK-2554
ewollesen
force-pushed
the
eric-cpa-alerts2
branch
from
12cee7d to
13aec20
Compare
ewollesen
force-pushed
the
eric-cpa-alerts
branch
from
8367902 to
2ea9686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through discussions it was confirmed that Repeat is not universal to all alerts. So it's lifted out of the Base alert and re-inserted into those alerts where it should be present (namely Low and High alerts only).
BACK-2554