Repository navigation
TideSQL-MySQL 2 MAJOR (v2.0.0) - #3
Merged
Merged
Conversation
cmake reads TIDESDB_VERSION from the installed tidesdb/tidesdb_version.h and refuses to configure against a library whose major is not the one this plugin major pairs with.the linker cannot catch it: the soname carries the major, so a mismatch surfaces at load as a missing library, or at run time as a format the engine misreads.a missing version header, an unparseable version and a wrong major each say so separately rather than failing the same way. install.sh grows --mysql-src, to build against a mysql source tree the caller already has instead of cloning one.it validates the path is a mysql tree, and prepare_mysql no longer deletes or clones over a tree it was handed.every path that named the cloned tree now goes through it, so --rebuild-plugin works against an external checkout. --s3 is removed.TIDESDB_WITH_S3 is read by no cmakelists and no source in either the plugin or the library, so the flag passed a define nothing acted on; the rebuild path re-ran cmake only to sync it, and no longer re-runs cmake at all. the paired library moves to tidesdb v10.1.1, in VERSIONING.md, the format table, manual.json, the preface and the compatibility page. install.sh pins the paired tidesdb release (v10.1.1) instead of resolving to whatever is newest, so a fresh install cannot drift onto a library this release was never tested against.--tidesdb-version still overrides, and cmake still refuses a different major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pin the tidesdb major at build time, add --mysql-src, drop --s3
cmake reads TIDESDB_VERSION from the installed tidesdb/tidesdb_version.h
and refuses to configure against a library whose major is not the one
this plugin major pairs with.the linker cannot catch it: the soname
carries the major, so a mismatch surfaces at load as a missing library,
or at run time as a format the engine misreads.a missing version
header, an unparseable version and a wrong major each say so
separately rather than failing the same way.
install.sh grows --mysql-src, to build against a mysql source tree the
caller already has instead of cloning one.it validates the path is a
mysql tree, and prepare_mysql no longer deletes or clones over a tree
it was handed.every path that named the cloned tree now goes through
it, so --rebuild-plugin works against an external checkout.
--s3 is removed.TIDESDB_WITH_S3 is read by no cmakelists and no
source in either the plugin or the library, so the flag passed a
define nothing acted on; the rebuild path re-ran cmake only to sync
it, and no longer re-runs cmake at all.
the paired library moves to tidesdb v10.1.1, in VERSIONING.md, the
format table, manual.json, the preface and the compatibility page.
install.sh pins the paired tidesdb release (v10.1.1) instead of
resolving to whatever is newest, so a fresh install cannot drift onto
a library this release was never tested against.--tidesdb-version
still overrides, and cmake still refuses a different major