Skip to content

Remove duplicate \cr #6525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yutannihilation
Copy link
Member

Close #6509

Currently, the generated \tabular for "Aesthetics" section uses double \cr. But, guessing from what is described in WRE, it's unnecessary.

... The second argument consists of an arbitrary number of lines separated by \cr, and with fields separated by \tab. For example:

  \tabular{rlll}{
    [,1] \tab Ozone   \tab numeric \tab Ozone (ppb)\cr
    [,2] \tab Solar.R \tab numeric \tab Solar R (lang)\cr
    [,3] \tab Wind    \tab numeric \tab Wind (mph)\cr
    [,4] \tab Temp    \tab numeric \tab Temperature (degrees F)\cr
    [,5] \tab Month   \tab numeric \tab Month (1--12)\cr
    [,6] \tab Day     \tab numeric \tab Day of month (1--31)
  }

This was added in #6285, but I found no particular reason. So, I guess we can just remove this.

@teunbrand
Copy link
Collaborator

Thanks @yutannihilation for taking this on! Does the pkgdown site look normal now? I always forgot what I can and can't preview with pkgdown

@yutannihilation
Copy link
Member Author

It seems fine! This is the local preview by pkgdown::build_site().

image

@yutannihilation
Copy link
Member Author

This is the local preview of ?geom_hex. This also looks fine.

image

Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah that looks great, thank for posting the pictures! I honestly can't quite recall why I put two \cr there, but this is a great improvement.

@yutannihilation
Copy link
Member Author

Thanks for approving! Let's merge and see if this fixes the actual pkgdown site.

@yutannihilation yutannihilation merged commit c68d9fc into tidyverse:main Jun 20, 2025
13 checks passed
@yutannihilation yutannihilation deleted the doc/fix-aesthetic-section-format branch June 20, 2025 11:18
@yutannihilation
Copy link
Member Author

I checked several pages on the pkgdown site, and all look fine now 🎉

https://ggplot2.tidyverse.org/dev/reference/index.html

@teunbrand
Copy link
Collaborator

Yeah looks much better, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aesthetics roxygen tag is broken on pkgdown site
2 participants