Don't mention iris dataset in documentation #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
reviewed
Aug 15, 2024
R/read_excel.R
Outdated
| #' | ||
| #' # Recycle a single column type | ||
| #' read_excel(datasets, col_types = "text") | ||
| #' | ||
| #' # Specify some col_types and guess others | ||
| #' read_excel(datasets, col_types = c("text", "guess", "numeric", "guess", "guess")) | ||
| #' read_excel(datasets, col_types = rep("guess", 11)) |
There was a problem hiding this comment.
This change directly contradicts the comment just above it. Can you target a different worksheet and hold on to the intent of the example?
There was a problem hiding this comment.
So true! Thanks for pointing this out 😊 I've updated this now with a better example!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #642
Problem:
irisdataset is stored indataset.xlsxanddataset.xls.irisis used in various examples to illustrate the functionality ofreadxl, the goal is to remove thisirisor replace it with another nicer dataset e.g. penguins 🐧After chats with Garrick and Emil, they suggested the smallest scoped solution is to remove any public facing documentation is uses
irisand ignore the test files that uses iris.@drorberel and I decided to remove the iris spreadsheet and update the README files, vignettes and any examples in .R that refer to
iris.Hope that we didn't cause any downstream breakages! 😄