Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

auto/fix_inline_expansion #710

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Nov 19, 2021

Description

tf2_eigen.hが定義されていなかったため arc_lane_util.hppにinlineで定義されている関数がruntime時に死ぬため修正

Review Procedure

柏の葉の地図で死なないことの確認
image

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@taikitanaka3
Copy link
Contributor Author

taikitanaka3 commented Nov 19, 2021

@kenji-miyake @wep21
.hppにあるとruntime時におちるのですが、こちらなにかわかりそうでしょうか?(.ivの方ではでは正常に動いてました。)

@kenji-miyake
Copy link
Contributor

mm... I'm sorry I'm not sure. 🥺

@TakaHoribe
Copy link
Contributor

TakaHoribe commented Nov 19, 2021

こういう問題の適切な追い方が知りたい

@kmiya
Copy link
Contributor

kmiya commented Nov 19, 2021

I'm not sure, but there might be a missing header like this #664.

@taikitanaka3
Copy link
Contributor Author

@kmiya
thankyou #include <tf2_geometry_msgs/tf2_geometry_msgs.h> is already in this file and

@taikitanaka3
Copy link
Contributor Author

there may be some linking error in Eigen
ros2/geometry2#368

@taikitanaka3
Copy link
Contributor Author

taikitanaka3 commented Nov 22, 2021

@TakaHoribe @tkimura4
tf2_geometry_msgs was not the package which is used here, instead this package(tf2_eigen) was necessary
http://docs.ros.org/en/jade/api/tf2_eigen/html/tf2__eigen_8h.html

but tf2_geometry_msgs has a template and it doesnt print error when building

fixed at 3828316
image

the reason why moving this function to cpp works was that cpp file includes tf2_eigen.h

@taikitanaka3 taikitanaka3 force-pushed the auto/fix/runtime_error branch from 839820f to 3828316 Compare November 22, 2021 05:42
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@tkimura4 tkimura4 merged commit e953bc2 into use-autoware-auto-msgs Nov 22, 2021
@tkimura4 tkimura4 deleted the auto/fix/runtime_error branch November 22, 2021 06:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants