Fix specific resource#278
Open
duncdrum wants to merge 2 commits into
Open
Conversation
duncdrum
force-pushed
the
fix-specificResource
branch
from
c46850d to
2b91267
Compare
Contributor
|
Thanks a lot, @duncdrum! Since this is a larger change and may be affected by the @iiif/parser package, which we are about to update, this may take some time to review. Thank you for your patience, I will keep you updated. |
Author
|
@t11r Any reason why you wouldn't approve a CI run? While I did run the tests locally, I consider ci to be the source of truth. So I m curious to see if the changes actually have side effects. |
mock manifest simulates open-fold -single page interlinking
…navigation links to target canvases
t11r
force-pushed
the
fix-specificResource
branch
from
2b91267 to
5b8b0da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled across this during client work. All viewer tested struggled with this type of annotation in some form or the other.
closes #277