Add FFLAGS #178
Open
Add FFLAGS #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be good to verify this first then. They are CMake environment variables, so you should be able to see signs of them being used in things that use CMake. |
Yes, I did not find any hints here. But then again, not everything is visible in Cmake's logs (eg. #161). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
FFLAGS. I am not sure about this. What do you think?I found no evidence that the flags are used anywhere, but on the other hand there is a Fortran code that is compiled. So there is a chance that it might speed something up, especially if PyBDSF is built locally (#175). And it is only 2 lines of code.
The container does compile.