refactor(parser): migrate to unified function API - #111
Conversation
2470390 to
aae6cd0
Compare
|
|
||
| from tilefoundry.ir.hir._call_binding import set_authoring_reader # noqa: E402 | ||
|
|
||
| set_authoring_reader(_authored_child_call) |
There was a problem hiding this comment.
Why is this code? In this way, it will be executed when it becomes import.
|
|
||
|
|
||
| @lru_cache(maxsize=1) | ||
| def _runtime() -> SimpleNamespace: |
There was a problem hiding this comment.
Isn’t this paragraph the compatible code used for development? Why don‘t you delete it?
| ) | ||
| from tilefoundry.ir.types.shard.shard_layout import ShardLayout | ||
| from tilefoundry.parser.sugar import parse_sugar | ||
| from tilefoundry.ir.types.shard.sugar import parse_sugar |
There was a problem hiding this comment.
Why is Parser Sugar imported from there? Shouldn’t it be a part of Parser? Then I don‘t think the position of this test is reasonable.
|
CI run 32637567894 completed. Pre-commit passed; the test job reproduced the same five baseline failures as the clean-main verification (879 passed, 5 failed, 4 skipped), with no new M11-specific failures. The run stopped before wheel/install checks because the repository CI treats baseline failures as job failure. Local fresh evidence for commit |
|
Follow-up CI run 32638014364 on docs commit |
Why
What
CallPattern -> ConstantPattern -> Cast Callpath.tests/parserand update the parser spec.Contract
parse_function(fn, context)remains the only parser entry point.Cast(Constant)combinations.Risk
test_results/parser-scalar-call-*-full-r1/.