Skip to content

[Feat][Linear-Attn] Update GDN prefill manifest contract#1601

Merged
lcy-seso merged 2 commits into
tile-ai:mainfrom
superAngGao:spec/gdn-prefill-manifest-layout
Jun 21, 2026
Merged

[Feat][Linear-Attn] Update GDN prefill manifest contract#1601
lcy-seso merged 2 commits into
tile-ai:mainfrom
superAngGao:spec/gdn-prefill-manifest-layout

Conversation

@superAngGao

Copy link
Copy Markdown
Collaborator

Summary

  • update the GatedDeltaNetPrefillFwdOp spec-only manifest contract to allow chunk_size=None
  • add the layout parameter used by the implementation path
  • add an H16/S2K manifest workload row for the target prefill shape family

Notes

Validation

  • python scripts/validate_manifest.py --check-op GatedDeltaNetPrefillFwdOp

@superAngGao superAngGao requested a review from a team June 21, 2026 08:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GatedDeltaNetPrefillFwdOp manifest in tileops/manifest/linear_attention.yaml to support a nullable chunk_size (defaulting to null), introduces a new layout parameter defaulting to "bhtd", and adds a new benchmark workload. The review feedback suggests changing the default layout to "bhsd" to maintain consistency with the BHSD shape rules used elsewhere in the codebase, and adding a benchmark workload that explicitly tests the chunk_size: null configuration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tileops/manifest/linear_attention.yaml
Comment thread tileops/manifest/linear_attention.yaml
@superAngGao superAngGao changed the title [Spec] Update GDN prefill manifest contract [Feat][Linear-Attn] Update GDN prefill manifest contract Jun 21, 2026
@lcy-seso lcy-seso merged commit e38c5b3 into tile-ai:main Jun 21, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants