Skip to content

[Doc] Ascend: refine T.tile.sin/cos docstrings, add test cases and API documentation - #1677

Open
fredrekelthen wants to merge 8 commits into
tile-ai:ascendc_ptofrom
fredrekelthen:refine-tile-sin-cos-doc
Open

[Doc] Ascend: refine T.tile.sin/cos docstrings, add test cases and API documentation#1677
fredrekelthen wants to merge 8 commits into
tile-ai:ascendc_ptofrom
fredrekelthen:refine-tile-sin-cos-doc

Conversation

@fredrekelthen

@fredrekelthen fredrekelthen commented Aug 24, 2026

Copy link
Copy Markdown

改动内容

  • tilelang/language/ascend_tile.py:精炼 sin/cos docstring(dtype 支持、原地运算、PTO 不支持、tmp workspace 字节数、IEEE 特殊值、大小断言)
  • testing/python/base/unary_op.py:新增 unsupported_targets spec 字段与 skip_if_unsupported_target(默认空列表,既有套件行为不变)
  • testing/python/language/test_tile_sin.py / test_tile_cos.py:基于共享一元框架注册(Compile / E2E / Boundary);PTO 参数跳过(编译期拒绝)、skip_inf_special 覆盖 IEEE 语义 sin/cos(inf)=nan
  • docs/language/tile_sin.md / tile_cos.md:经真机验证的 API 文档(无 A5 平台行;dtype 矩阵、精度、特殊值均实测确认)
  • request/说明和审查/:更新 框架.mddebug error #17-chore: remove incompatible code temporarily #21)并新增 sin/cos 批次更新说明

测试

真机 Ascend910B3(dav-2201),ascendc 后端全量验证:

  • 每个批次 60 例(每 API 30 例),28 passed + 32 skipped(跳过 = PTO 不支持 + sin/cos(inf)≠inf 的 IEEE 覆盖)
  • PR 阶段子集(-m "not (low_priority or ci_skip)"):6 例(每 API 3 例)
  • 已确认事实:仅 f16/f32 支持(int16/int32/bf16 编译失败);ascendc 支持原地运算;特殊值符合 IEEE;f16 max_rel≈5e-4、f32 max_abs≈1e-7
  • ruff / py_compile / git diff --check 全部通过

依赖 #1657(relu/silu 批次)及 #1613/#1636(一元框架基础),经分支链继承。

adduser added 7 commits August 18, 2026 11:42
…ew feedback 🤖

Shared with tile-ai#1615: 2.2 src1 described as "tensor or scalar" (BufferLoad
is a scalar form, not a user-facing tvm concept); remove the 2.3.3
src1-form table whose implementation column only covered the AscendC
backend and whose tvm internal type names (BufferRegion/PrimExpr/
BufferLoad) duplicate 2.1 signatures.
…I documentation 🤖

- Refine sin/cos docstrings in ascend_tile.py (dtype/inplace/PTO/tmp/special values)
- Add unsupported_targets support to the unary test framework (pto skip)
- Add test_tile_sin.py / test_tile_cos.py registered against the unary framework
- Add docs/language/tile_sin.md / tile_cos.md API documentation
- Record framework findings in request/说明和审查/框架.md (tile-ai#17-tile-ai#21)
- Add update notes for the sin/cos batch
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run bash format.sh in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work!

🚀

@fredrekelthen fredrekelthen changed the title [Doc] Ascend: refine T.tile.sin/cos docstrings, add test cases and API documentation 🤖 [Doc] Ascend: refine T.tile.sin/cos docstrings, add test cases and API documentation Aug 24, 2026
…rkers 🤖

Sync with PR tile-ai#1615 (commit e994015): drop the custom l0/l1/l2/
compile_time marker definitions; gate/functional/compile-time cases run
by default in PR CI, boundary cases become low_priority. Fix
scalar_golden (torch.maximum needs a Tensor) and test_inf_input
(min(+inf,1)=1) in base/binary_op.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant