Proof-of-concept work to identify & fix sources of logging loops #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I run with debug console typically, and typically after a few hours of playing the logging loops are so bad the game slows down. So I went after the problem. The bulk of the logs that loop and don't go away are caused by AppliedQueuedEffects and related routines. These "queue" effects until conditions are met like actors being fully created, or assigned a server ID. But the problem is they never give up; they try and log endlessly. If you are a magic user (I usually am), the build up over time until the game is unplayable. |
Force67
reviewed
Dec 4, 2024
maximegmd
requested changes
Dec 4, 2024
… messages that repeat forever). For discussion. Would never propose merging such ugly hacks.
rfortier
force-pushed
the
fix/excess-logging-bugs
branch
from
c470d10 to
6a9e2d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(log messages that repeat forever).
For discussion. Would never propose merging such ugly hacks.