add more tests and simplify promise use within them #369
+260
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeiscontent
commented
Nov 17, 2025
Author
|
ready for review. |
tim-smart
requested changes
Nov 24, 2025
| expect(Result.isInitial(result2)).toBe(true) | ||
| }) | ||
|
|
||
| it("Interrupt symbol", () => { |
Owner
There was a problem hiding this comment.
This needs to actually test the functionality.
Author
There was a problem hiding this comment.
my bad, turns out I had forgotten to push the latest change. should be good for another review.
There was a problem hiding this comment.
Pull request overview
This pull request simplifies test code and significantly expands test coverage for the Atom API. The primary changes include replacing verbose promise patterns with cleaner syntax and adding 17 new comprehensive test cases.
- Refactored
await new Promise((resolve) => resolve(null))to the simplerawait Promise.resolve()throughout the test file - Added extensive test coverage for Atom features including mapping, debouncing, context utilities, type guards, modifiers, and special symbols
- Improved test readability and maintainability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lifeiscontent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
packages/atom/test/Atom.test.tsfile to both simplify test code and add extensive new test coverage for theAtomAPI. The main change is replacing verboseawait new Promise((resolve) => resolve(null))statements with the simplerawait Promise.resolve(). Additionally, a large suite of new tests has been added to cover variousAtomfeatures, such as mapping, debouncing, context utilities, type guards, modifiers, and special symbols likeResetandInterrupt.