feat(server): add GitHub OAuth provider#16
Merged
Conversation
- Add github.ts with OAuth implementation for GitHub - GitHub tokens don't expire (no refresh token support) - Fetch primary email from /user/emails if not public - Update provider registry to route to GitHub functions - Remove 'not implemented' check from device code handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/user/emailsendpoint when email is not public on profileChanges
New file:
packages/server/auth/providers/github.tsgetGitHubConfig()- returns client ID and scopes (read:user,user:email)buildGitHubAuthUrl()- constructs GitHub authorization URLexchangeGitHubCode()- exchanges authorization code for access tokenfetchGitHubUserInfo()- fetches user profile and emailfetchGitHubPrimaryEmail()- helper to get primary email from emails endpointUpdated:
packages/server/auth/providers/index.tsUpdated:
packages/server/handlers/auth.tsTesting
All 234 existing tests pass. The OAuth callback handler was already generic enough to handle both providers - no changes needed there.
Notes
expiresAtfield is set tonullfor GitHub tokens to reflect this