fix delete/move tree dry-run count cap at 1000 (TNT-59)#50
Merged
jgpruitt merged 1 commit intoApr 27, 2026
Merged
Conversation
The dryRun branches of memory.deleteTree and memory.move used searchMemories with limit:1000 and returned its total, but total is just the length of the limited result set — so previews capped at 1000 even when more rows would be affected. Add a memory.countTree op/RPC method that does an unbounded COUNT(*) under the tree path, and route both dry-run paths through it. Expose countTree on the engine client too.
jgpruitt
deleted the
jgpruitt/tnt-59-delete-command-may-show-incorrect-count
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dryRun branches of memory.deleteTree and memory.move used searchMemories with limit:1000 and returned its total, but total is just the length of the limited result set — so previews capped at 1000 even when more rows would be affected.
Add a memory.countTree op/RPC method that does an unbounded COUNT(*) under the tree path, and route both dry-run paths through it. Expose countTree on the engine client too.