fix: replace stale Phase 1 warning for dynamic pipelines#98
Merged
Conversation
The load_pipelines() warning "source resolution not yet supported" was added during Phase 1 (PR #86) when source resolution did not exist. Phases 2-3 (PR #87-#88) added full resolution in rsigma-runtime and the daemon, but the shared warning was never updated. The daemon resolves sources correctly after load_pipelines() runs, making the warning misleading. Replace the blanket warning with a neutral "dynamic source(s): ..." info line in load_pipelines(), and add targeted notes in eval, convert, and fields commands explaining that these sync-only commands do not resolve dynamic sources and directing users to rsigma resolve or rsigma daemon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_pipelines()warning "source resolution not yet supported" was added during Phase 1 (PR feat(pipeline): add dynamic source detection and parsing #86) when source resolution did not exist. Phases 2-3 (PRs feat: dynamic pipeline source resolution engine (Phase 2-3) #87-feat: Phase 3b + deferred features (extract languages, cache TTL, NATS control, CLI flags) #88) added full resolution inrsigma-runtimeand the daemon, but the shared warning inload_pipelines()was never updated. The daemon resolves sources correctly afterload_pipelines()runs, making the old warning misleading.dynamic source(s): ...info line inload_pipelines(), and add targeted notes ineval,convert, andfieldscommands explaining that these sync-only commands do not resolve dynamic sources and directing users torsigma resolveorrsigma daemon.Changes
main.rs(load_pipelines): Replace misleading "source resolution not yet supported" withdynamic source(s): <ids>commands/eval.rs: Add note thatrsigma evaldoes not resolve dynamic sourcescommands/convert.rs: Add note thatrsigma convertdoes not resolve dynamic sourcescommands/fields.rs: Add note thatrsigma fieldsdoes not resolve dynamic sourcesTest plan
cargo test --workspacepassescargo clippy --workspace --all-targets --all-features -- -D warningspassescargo fmt --all -- --checkpassesrsigma evalwith dynamic pipeline shows the new note instead of the old warningrsigma resolvestill resolves sources correctly (no change to resolve path)