refactor(db): introduce DBTX interface for query abstraction [1/2]#26
Open
rlindgren wants to merge 2 commits into
Open
refactor(db): introduce DBTX interface for query abstraction [1/2]#26rlindgren wants to merge 2 commits into
rlindgren wants to merge 2 commits into
Conversation
Replace *pgxpool.Pool with a DBTX interface in all ~60 package-level db functions. DBTX is satisfied by both *pgxpool.Pool and pgx.Tx, following the sqlc convention. This enables future session variable scoping via SET LOCAL in transactions without changing callers. Zero behavior change: all Client methods continue to pass c.pool, which satisfies DBTX. No new dependencies, no test changes required.
|
|
rlindgren
changed the title
# Conflicts: # internal/tigerfs/db/query.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace *pgxpool.Pool with a DBTX interface in all ~60 package-level db functions. DBTX is satisfied by both *pgxpool.Pool and pgx.Tx, following the sqlc convention. This enables future session variable scoping via SET LOCAL in transactions without changing callers.
Zero behavior change: all Client methods continue to pass c.pool, which satisfies DBTX. No new dependencies, no test changes required.
This PR is 1 of 2. It introduces the DBTX interface used by the session variable scoping in PR #27 which contains the complete description of the motivation, design and api changes