Skip to content

Conversation

@lexzaiello
Copy link
Contributor

@lexzaiello lexzaiello commented Aug 21, 2024

Closes #24 #23 #22 #11 . This PR mainly refactors queries.rs to all use the existing TestContextQuery pattern, instead of argument-based queries. These queries are used in very few places, so now was the best time to migrate them. Furthermore, in doing so, this PR enables chain-agnostic tx_build_xyz calls, which allows, for example, instantiating an astroport factory on Osmosis. This is required for passive concentrated liquidity tests.

Todo

  • Handle gov prop stuff for whitelisting PCL contracts on Osmosis

Summary of Changes

  • Refactor all queries to TestContextQuery
  • Add .with_chain to all necessary builders
    • For example, build_tx_upload_contracts, which does not take a chain at all and assumes Neutron
  • Remove singleton contract instantiation information from the top-level TestContext (allows instantiating a factory, for example, on Osmosis and Neutron), in favor of LocalChain-specific singleton-style instantiations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store Contract Addresses Per-Chain, Not Globally

2 participants