Skip to content

chore(deps): update eslint monorepo to v10 - #34

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-eslint-monorepo
Open

chore(deps): update eslint monorepo to v10#34
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-eslint-monorepo

Conversation

@renovate

@renovate renovate Bot commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
@eslint/js (source) 9.39.3 → 10.0.1 age confidence
eslint (source) 9.39.3 → 10.13.0 age confidence

Release Notes

eslint/eslint (@​eslint/js)

v10.0.1

Compare Source

Bug Fixes

Documentation

  • 5b3dbce docs: add AI acknowledgement section to templates (#​20431) (루밀LuMir)
  • 6f23076 docs: toggle nav in no-JS mode (#​20476) (Tanuj Kanti)
  • b69cfb3 docs: Update README (GitHub Actions Bot)

Chores

v10.0.0

Compare Source

Breaking Changes

  • f9e54f4 feat!: estimate rule-tester failure location (#​20420) (ST-DDT)
  • a176319 feat!: replace chalk with styleText and add color to ResultsMeta (#​20227) (루밀LuMir)
  • c7046e6 feat!: enable JSX reference tracking (#​20152) (Pixel998)
  • fa31a60 feat!: add name to configs (#​20015) (Kirk Waiblinger)
  • 3383e7e fix!: remove deprecated SourceCode methods (#​20137) (Pixel998)
  • 501abd0 feat!: update dependency minimatch to v10 (#​20246) (renovate[bot])
  • ca4d3b4 fix!: stricter rule tester assertions for valid test cases (#​20125) (唯然)
  • 96512a6 fix!: Remove deprecated rule context methods (#​20086) (Nicholas C. Zakas)
  • c69fdac feat!: remove eslintrc support (#​20037) (Francesco Trotta)
  • 208b5cc feat!: Use ScopeManager#addGlobals() (#​20132) (Milos Djermanovic)
  • a2ee188 fix!: add uniqueItems: true in no-invalid-regexp option (#​20155) (Tanuj Kanti)
  • a89059d feat!: Program range span entire source text (#​20133) (Pixel998)
  • 39a6424 fix!: assert 'text' is a string across all RuleFixer methods (#​20082) (Pixel998)
  • f28fbf8 fix!: Deprecate "always" and "as-needed" options of the radix rule (#​20223) (Milos Djermanovic)
  • aa3fb2b fix!: tighten func-names schema (#​20119) (Pixel998)
  • f6c0ed0 feat!: report eslint-env comments as errors (#​20128) (Francesco Trotta)
  • 4bf739f fix!: remove deprecated LintMessage#nodeType and TestCaseError#type (#​20096) (Pixel998)
  • 523c076 feat!: drop support for jiti < 2.2.0 (#​20016) (michael faith)
  • 454a292 feat!: update eslint:recommended configuration (#​20210) (Pixel998)
  • 4f880ee feat!: remove v10_* and inactive unstable_* flags (#​20225) (sethamus)
  • f18115c feat!: no-shadow-restricted-names report globalThis by default (#​20027) (sethamus)
  • c6358c3 feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24 (#​20160) (Milos Djermanovic)

Features

  • bff9091 feat: handle Array.fromAsync in array-callback-return (#​20457) (Francesco Trotta)
  • 290c594 feat: add self to no-implied-eval rule (#​20468) (sethamus)
  • 43677de feat: fix handling of function and class expression names in no-shadow (#​20432) (Milos Djermanovic)
  • f0cafe5 feat: rule tester add assertion option requireData (#​20409) (fnx)
  • f7ab693 feat: output RuleTester test case failure index (#​19976) (ST-DDT)
  • 7cbcbf9 feat: add countThis option to max-params (#​20236) (Gerkin)
  • f148a5e feat: add error assertion options (#​20247) (ST-DDT)
  • 09e6654 feat: update error loc of require-yield and no-useless-constructor (#​20267) (Tanuj Kanti)

Bug Fixes

  • 436b82f fix: update eslint (#​20473) (renovate[bot])
  • 1d29d22 fix: detect default this binding in Array.fromAsync callbacks (#​20456) (Francesco Trotta)
  • 727451e fix: fix regression of global mode report range in strict rule (#​20462) (ntnyq)
  • e80485f fix: remove fake FlatESLint and LegacyESLint exports (#​20460) (Francesco Trotta)
  • 9eeff3b fix: update esquery (#​20423) (cryptnix)
  • b34b938 fix: use Error.prepareStackTrace to estimate failing test location (#​20436) (Francesco Trotta)
  • 51aab53 fix: update eslint (#​20443) (renovate[bot])
  • 23490b2 fix: handle space before colon in RuleTester location estimation (#​20433) (Francesco Trotta)
  • f244dbf fix: use MessagePlaceholderData type from @eslint/core (#​20348) (루밀LuMir)
  • d186f8c fix: update eslint (#​20427) (renovate[bot])
  • 2332262 fix: error location should not modify error message in RuleTester (#​20421) (Milos Djermanovic)
  • ab99b21 fix: ensure filename is passed as third argument to verifyAndFix() (#​20405) (루밀LuMir)
  • 8a60f3b fix: remove ecmaVersion and sourceType from ParserOptions type (#​20415) (Pixel998)
  • eafd727 fix: remove TDZ scope type (#​20231) (jaymarvelz)
  • 39d1f51 fix: correct Scope typings (#​20404) (sethamus)
  • 2bd0f13 fix: update verify and verifyAndFix types (#​20384) (Francesco Trotta)
  • ba6ebfa fix: correct typings for loadESLint() and shouldUseFlatConfig() (#​20393) (루밀LuMir)
  • e7673ae fix: correct RuleTester typings (#​20105) (Pixel998)
  • 53e9522 fix: strict removed formatters check (#​20241) (ntnyq)
  • b017f09 fix: correct no-restricted-import messages (#​20374) (Francesco Trotta)

Documentation

  • e978dda docs: Update README (GitHub Actions Bot)
  • 4cecf83 docs: Update README (GitHub Actions Bot)
  • c79f0ab docs: Update README (GitHub Actions Bot)
  • 773c052 docs: Update README (GitHub Actions Bot)
  • f2962e4 docs: document meta.docs.frozen property (#​20475) (Pixel998)
  • 8e94f58 docs: fix broken anchor links from gerund heading updates (#​20449) (Copilot)
  • 1495654 docs: Update README (GitHub Actions Bot)
  • 0b8ed5c docs: document support for :is selector alias (#​20454) (sethamus)
  • 1c4b33f docs: Document policies about ESM-only dependencies (#​20448) (Milos Djermanovic)
  • 3e5d38c docs: add missing indentation space in rule example (#​20446) (fnx)
  • 63a0c7c docs: Update README (GitHub Actions Bot)
  • 65ed0c9 docs: Update README (GitHub Actions Bot)
  • b0e4717 docs: [no-await-in-loop] Expand inapplicability (#​20363) (Niklas Hambüchen)
  • fca421f docs: Update README (GitHub Actions Bot)
  • d925c54 docs: update config syntax in no-lone-blocks (#​20413) (Pixel998)
  • 7d5c95f docs: remove redundant sourceType: "module" from rule examples (#​20412) (Pixel998)
  • 02e7e71 docs: correct .mts glob pattern in files with extensions example (#​20403) (Ali Essalihi)
  • 264b981 docs: Update README (GitHub Actions Bot)
  • 5a4324f docs: clarify "local" option of no-unused-vars (#​20385) (Milos Djermanovic)
  • e593aa0 docs: improve clarity, grammar, and wording in documentation site README (#​20370) (Aditya)
  • 3f5062e docs: Add messages property to rule meta documentation (#​20361) (Sabya Sachi)
  • 9e5a5c2 docs: remove Examples headings from rule docs (#​20364) (Milos Djermanovic)
  • 194f488 docs: Update README (GitHub Actions Bot)
  • 0f5a94a docs: [class-methods-use-this] explain purpose of rule (#​20008) (Kirk Waiblinger)
  • df5566f docs: add Options section to all rule docs (#​20296) (sethamus)
  • adf7a2b docs: no-unsafe-finally note for generator functions (#​20330) (Tom Pereira)
  • ef7028c docs: Update README (GitHub Actions Bot)
  • fbae5d1 docs: consistently use "v10.0.0" in migration guide (#​20328) (Pixel998)
  • 778aa2d docs: ignoring default file patterns (#​20312) (Tanuj Kanti)
  • 4b5dbcd docs: reorder v10 migration guide (#​20315) (Milos Djermanovic)
  • 5d84a73 docs: Update README (GitHub Actions Bot)
  • 37c8863 docs: fix incorrect anchor link in v10 migration guide (#​20299) (Pixel998)
  • 077ff02 docs: add migrate-to-10.0.0 doc (#​20143) (唯然)
  • 3822e1b docs: Update README (GitHub Actions Bot)

Build Related

  • 9f08712 Build: changelog update for 10.0.0-rc.2 (Jenkins)
  • 1e2c449 Build: changelog update for 10.0.0-rc.1 (Jenkins)
  • c4c72a8 Build: changelog update for 10.0.0-rc.0 (Jenkins)
  • 7e4daf9 Build: changelog update for 10.0.0-beta.0 (Jenkins)
  • a126a2a build: add .scss files entry to knip (#​20389) (Francesco Trotta)
  • f5c0193 Build: changelog update for 10.0.0-alpha.1 (Jenkins)
  • 165326f Build: changelog update for 10.0.0-alpha.0 (Jenkins)

Chores

v9.39.5

Compare Source

Bug Fixes

Documentation

Chores

  • 458205f chore: update @eslint/eslintrc and @eslint/js for v9.39.5 (#​21077) (Francesco Trotta)
  • 202117b chore: package.json update for @​eslint/js release (Jenkins)
  • d9eb6ed test: disable warning for vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER (#​21074) (Francesco Trotta)
  • 7b431a7 chore: override re2 dependency for @metascraper/helpers (#​21068) (Milos Djermanovic)
  • daf7791 chore: pin fflate@​0.8.2 (#​20895) (Milos Djermanovic)
  • daee8ba ci: use pnpm in eslint-flat-config-utils type integration test (#​20829) (Milos Djermanovic)
  • 116d4be ci: unpin Node.js 25.x in CI (#​20619) (Copilot)

v9.39.4

Compare Source

Bug Fixes

Documentation

Chores

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 6am on monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@coderabbitai

coderabbitai Bot commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ca562e84-301b-4445-8307-1cc7d294071c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch renovate/major-eslint-monorepo
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 11 times, most recently from e3a0403 to 628ef95 Compare March 11, 2026 06:39
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 5 times, most recently from 21a1ea9 to d5b51df Compare March 23, 2026 13:37
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from 47e72ab to a105028 Compare April 3, 2026 16:40
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from a105028 to 88b493c Compare April 8, 2026 20:37
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 5 times, most recently from 05ee7cb to a60fb96 Compare April 23, 2026 06:17
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 5 times, most recently from 3969271 to 64d951c Compare May 5, 2026 09:09
@timoa

timoa commented Sep 24, 2026

Copy link
Copy Markdown
Owner

DevSecOps daily sweep (2026-09-24): major bump (eslint monorepo v9→v10), Lint, Test, Build & Security FAILURE. Skipping. Requires human review.

timoa
timoa reviewed Sep 25, 2026
View reviewed changes

@timoa timoa left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevSecOps daily sweep flagged this PR as awaiting-human review.

Reason: major version bump. Even with green CI, major bumps can introduce breaking API changes, behavior shifts, or require code edits downstream of the lockfile. No autopilot approve or merge.

Please review the release notes and changelog before merging.

@timoa

timoa commented Sep 26, 2026

Copy link
Copy Markdown
Owner

CI gate failure: Lint, Test, Build & Security check FAILURE on this branch. Not eligible for auto-merge until CI is green. (autopilot TIM-376)

@timoa

timoa commented Sep 27, 2026

Copy link
Copy Markdown
Owner

🤖 DevSecOps sweep: Lint, Test, Build & Security is FAILING and the bump is MAJOR (eslint monorepo → v10). MAJOR requires human review; CI red blocks any merge. Please triage and merge manually once CI is green and approved.

@timoa

timoa commented Sep 28, 2026

Copy link
Copy Markdown
Owner

Renovate daily sweep (TIM-380): blocked on CI. Major bump eslint monorepo 9.39.3→10.10.0. Lint, Test, Build & Security failed. Major + failing CI; cannot auto-merge.

@timoa

timoa commented Oct 1, 2026

Copy link
Copy Markdown
Owner

CI gate failure: Lint, Test, Build & Security failed. Major bump (eslint monorepo 9.39.3→10.10.0). Auto-merge skipped. Please rebase or fix CI and re-run.

@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from c24e96b to aea363a Compare October 2, 2026 22:58
timoa
timoa reviewed Oct 4, 2026
View reviewed changes

@timoa timoa left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate eslint monorepo 9.39.3 → 10.x (@eslint/js + eslint). Semver major (v9 → v10). CI: 'Lint, Test, Build & Security' FAILURE. No labels. Major bump + red CI → human review required, no auto-merge.

@timoa

timoa commented Oct 5, 2026

Copy link
Copy Markdown
Owner

DevSecOps daily sweep (TIM-397): CI gate failing — Lint, Test, Build & Security check failed. Skipping auto-merge. This is a major bump (eslint v9 → v10). Rebase and retry.

@timoa

timoa commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Skipped: Lint, Test, Build & Security check failed on this run (2026-10-02). eslint monorepo 9.39.3→10.x (MAJOR semver; v10 drops eslintrc support, multiple breaking changes, requires Node 20.19+/22.13+). Renovate labels missing so no risk-tier. Awaiting CI fix before auto-merge can be re-evaluated. — DevSecOps autopilot (TIM-400)

@timoa

timoa commented Oct 7, 2026

Copy link
Copy Markdown
Owner

DevSecOps daily sweep: skipping auto-merge. 'Lint, Test, Build & Security' check is FAILURE. Major bump of eslint monorepo 9.39.3 → 10.11.0 (eslint + @eslint/js). Please address the lint/test/build failure, confirm major-version impact, and merge manually. No hard exclusions.

@timoa

timoa commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Renovate daily sweep 2026-10-08: blocked. Lint, Test, Build & Security failed (https://github.com/timoa/workflow-metrics/actions/runs/37075246805/job/111063592068). ESLint v10 is a major monorepo bump. Skipping until CI is green.

timoa
timoa reviewed Oct 9, 2026
View reviewed changes

@timoa timoa left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevSecOps daily sweep (TIM-409). No security/patch Renovate label → not eligible for auto-merge.

Scope: package.json + pnpm-lock.yaml. eslint monorepo 9.39.3 → 10.11.0 (major — eslint and @eslint/js).
CI: Lint, Test, Build & Security failed (run 37075246805). Other checks green.

Action: rebase + re-run. ESLint v10 has flat-config changes; expected lint breakage on v9 configs.

@timoa

timoa commented Oct 12, 2026

Copy link
Copy Markdown
Owner

Daily Renovate sweep 2026-10-12: Lint, Test, Build & Security check is FAILING. Not auto-merging. A human should investigate the failure before this can be merged.

@timoa

timoa commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Daily Renovate sweep (TIM-419): Lint, Test, Build & Security check is FAILURE on this PR, so the CI gate is not green. Not auto-mergeable. Awaiting human triage — either fix the failing lint/test job (likely root cause shared across most open Renovate PRs in this repo) or update this PR's branch. Will retry on the next sweep once CI is green.

@timoa

timoa commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Renovate autopilot: required check 'Lint, Test, Build & Security' FAILED in latest run (2026-10-02). Blocking auto-merge — please fix CI before re-running the daily Renovate sweep.

@timoa

timoa commented Oct 15, 2026

Copy link
Copy Markdown
Owner

🤖 DevSecOps daily sweep (TIM-430, 2026-10-15).

CI gate failure — not auto-merging. Lint, Test, Build & Security check is FAILURE; other checks (cflite-pr, CodeQL-Build, dependency-review, Detect changes, CodeQL, CodeRabbit, renovate/stability-days) green.

Skipping until the Lint/Test/Build pipeline is green. Major-version bump (eslint monorepo 9 → 10, including @eslint/js) needs human approval per the autopilot's risk-tier rules.

No diff touches .github/workflows/** / .env* / auth/ or other hard-exclusion paths, so the only blocker is CI.

@timoa

timoa commented Oct 16, 2026

Copy link
Copy Markdown
Owner

Renovate daily sweep (TIM-432) — skipping this PR. CI gate not green:

  • Lint, Test, Build & Security — FAILURE
  • cflite-pr, CodeQL-Build, dependency-review, Detect changes, CodeQL — SUCCESS
  • cflite-batch — SKIPPED

Diff: package.json + pnpm-lock.yaml (no hard-exclusion paths). Major bump of the eslint monorepo 9.39.3 → 10.11.0 (incl. @eslint/js). Lint fails.

This PR cannot be auto-merged. ESLint 9 → 10 is a major that often needs .eslintrc migration to flat-config flat files; @dev please verify, or close if 10.x is not desired yet.

@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from aea363a to 3799c9a Compare October 17, 2026 02:50
@timoa

timoa commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Renovate daily review — CI blocked: Lint, Test, Build & Security is failing. Bump is eslint monorepo 9→10 (MAJOR, two packages: eslint + @eslint/js). Workflow run: https://github.com/timoa/workflow-metrics/actions?query=branch%3Arenovate%2Fmajor-eslint-monorepo. Please fix CI or rebase.

@timoa

timoa commented Oct 19, 2026

Copy link
Copy Markdown
Owner

DevSecOps daily sweep (TIM-445, 2026-10-19): skipped-blocked. Lint, Test, Build & Security is FAILURE (eslint monorepo 9.39.3 → 10.12.0, major). Other checks green. No auto-merge attempted. ESLint 10 is a major release — review rule changes.

@timoa

timoa commented Oct 20, 2026

Copy link
Copy Markdown
Owner

DevSecOps sweep: skipping. Major eslint monorepo bump (9.39.3 → 10.12.0) and Lint, Test, Build & Security is FAILING. Requires human triage.

@timoa

timoa commented Oct 21, 2026

Copy link
Copy Markdown
Owner

DevSecOps daily sweep: 'Lint, Test, Build & Security' check FAILURE (run 38996475468). Major bump (eslint v9→v10) needs human review. Skipping auto-merge.

@timoa

timoa commented Oct 22, 2026

Copy link
Copy Markdown
Owner

DevSecOps daily sweep — blocked. Major bump of the eslint monorepo from 9.x to 10.0.1 (eslintrc support removed, Node engine raised to ^20.19.0 || ^22.13.0 || >=24, new JSX reference tracking). Lint, Test, Build & Security is failing on this branch. Requires human triage before merging.

@timoa

timoa commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Renovate sweep 2026-10-24 — CI gate failure, not merged.

Lint, Test, Build & Security fails (ELIFECYCLE Command failed with exit code 1).

This is a major bump of the eslint monorepo (v9 -> v10). ESLint 10 removes rules and changes config handling, so it needs a human to work through the migration rather than a machine merge.

@timoa

timoa commented Oct 25, 2026

Copy link
Copy Markdown
Owner

DevSecOps Renovate sweep 2026-10-25 — skipped-blocked.

Lint, Test, Build & Security = FAILURE (ELIFECYCLE Command failed with exit code 1), plus CodeQL-Build and renovate/artifacts FAILURE (stale lockfile).

eslint 9.39.3 -> 10.12.0 and @eslint/js 9.39.3 -> 10.0.1 is a major bump (eslintrc support removed, Node engine raised).

Not merged. Full sweep report: TIM-461.

@timoa

timoa commented Oct 26, 2026

Copy link
Copy Markdown
Owner

DevSecOps Renovate sweep 2026-10-26 — skipped-blocked.

Lint, Test, Build & Security fails. ESLint 10 adds the no-useless-assignment rule and it fires on existing source — 3 errors, unused assignments at lines 103, 110 and 113:

110:7  error  The value assigned to 'staleResponseData' is not used in subsequent statements  no-useless-assignment
113:6  error  The value assigned to 'tokenPermissions' is not used in subsequent statements  no-useless-assignment
103:7  error  The value assigned to 'repos' is not used in subsequent statements  no-useless-assignment

eslint 9.39.3 -> 10.12.0 (and @eslint/js 9.39.3 -> 10.0.1) is a major bump — eslintrc support removed, Node engine raised — so this needs code changes or a rule decision, not a machine merge.

All other checks green. Not merged.

Full sweep report: TIM-464.

timoa
timoa reviewed Oct 31, 2026
View reviewed changes

@timoa timoa left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevSecOps Renovate sweep 2026-10-31 — skipped-blocked (rebase did not clear the red).

New head 87213be (Renovate rebased 2026-10-30T17:02Z). CI re-ran on it and Lint, Test, Build & Security still fails at the Lint step — same root cause as the 2026-10-26 sweep, not a runner flake:

src/routes/api/dashboard/data/+server.ts   110:7  error  no-useless-assignment  (staleResponseData)
src/routes/api/optimize/apply/+server.ts   113:6  error  no-useless-assignment  (tokenPermissions)
src/routes/onboarding/+page.server.ts      103:7  error  no-useless-assignment  (repos)
✖ 3 problems (3 errors, 0 warnings)

ESLint 10 enables no-useless-assignment by default and it fires on pre-existing source, so a re-run will not clear it. This PR needs a code fix (drop the dead initializers) or an explicit rule exemption before it can merge. Not merged; not approved.

timoa
timoa reviewed Nov 5, 2026
View reviewed changes

@timoa timoa left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevSecOps Renovate sweep 2026-11-05 — skipped-blocked. Correction to my 2026-10-31 note: this bump causes the lint failure, it is not pre-existing.

Head 87213be, unchanged. Lint, Test, Build & Security still FAILURE at the Lint step, same 3 errors:

src/routes/api/dashboard/data/+server.ts   110:7  error  The value assigned to 'staleResponseData' is not used in subsequent statements  no-useless-assignment
src/routes/api/optimize/apply/+server.ts   113:6  error  The value assigned to 'tokenPermissions' is not used in subsequent statements  no-useless-assignment
src/routes/onboarding/+page.server.ts      103:7  error  The value assigned to 'repos' is not used in subsequent statements  no-useless-assignment
✖ 3 problems (3 errors, 0 warnings)

Correction. My 2026-10-31 comment said the rule "fires on pre-existing code", which implied the lint failure predates this branch. That is wrong — the rule does not exist in the tree before this PR:

  • This diff bumps @eslint/js 9.39.3 → 10.0.1 (and eslint 9.39.3 → 10.13.0, @eslint/config-array 0.21.1 → 0.23.5).
  • @eslint/js@9.39.3 configs.recommended = 61 rules, no no-useless-assignment (verified by unpacking the published tarball).
  • @eslint/js@10.0.1 configs.recommended = 64 rules, including "no-useless-assignment": "error".
  • eslint.config.js extends js.configs.recommended, so the rule turns on because of this bump.

main is lint-clean today. These 3 sites only start failing once the new rule is enabled — a genuine ESLint 10 migration break, not lint debt.

Recommendation: fix the 3 dead assignments (or pin @eslint/js back to 9.x in the same PR), then re-run CI. Major bump + red CI → not auto-merged by this sweep.

Human approval needed to proceed. Full sweep report: TIM-480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timoa timoa timoa left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@timoa