feat: Implement Lchown function for changing file ownership #5161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
commented
Jan 7, 2026
Itxaka
commented
- Added Lchown function to change the numeric uid and gid of a file or symbolic link.
- Included error handling to return *PathError for failed operations.
- Added unit tests for Lchown to verify behavior on different error scenarios.
- Added Lchown function to change the numeric uid and gid of a file or symbolic link. - Included error handling to return *PathError for failed operations. - Added unit tests for Lchown to verify behavior on different error scenarios.
Author
|
I think this is ok, but not sure about the libc part. I was mostly guided by the existing chown implementation to provide this one :D |
dgryski
requested changes
Jan 7, 2026
Member
dgryski
left a comment
dgryski
left a comment
There was a problem hiding this comment.
Just need to update the test. I'm not sure why CI is failing with internal/itoa issues.
src/os/os_chmod_test.go
Outdated
| "runtime" | ||
| "testing" | ||
|
|
||
| "github.com/tinygo-org/tinygo/src/os" |
Member
There was a problem hiding this comment.
The os package is already impred with . above. Remove.
src/os/os_chmod_test.go
Outdated
| f := newFile("TestLchown", t) | ||
| defer Remove(f.Name()) | ||
| defer f.Close() | ||
| link := filepath.Join(os.TempDir(), "TestLchownLink") |
src/os/os_chmod_test.go
Outdated
| defer Remove(f.Name()) | ||
| defer f.Close() | ||
| link := filepath.Join(os.TempDir(), "TestLchownLink") | ||
| _ = os.Symlink(f.Name(), link) |
Author
|
Fixed, thanks for the heads up. Cant believe I blatantly copied the test case from the chown and manage to broke it 😆 |
Member
|
@Itxaka please note that I changed the merge target to https://tinygo.org/docs/guides/contributing/#how-to-use-our-github-repository Now squash/merging. Thanks @Itxaka for the addition and to @dgryski for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.